fix(bom): make release-note-generation Java 8 compatible#13837
Merged
Conversation
This changes the target version to 1.8 and replaces Java 9+ API usage. TAG=agy CONV=f312eaf9-61ab-449f-868d-eae4d12a1830
TAG=agy CONV=f312eaf9-61ab-449f-868d-eae4d12a1830
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request downgrades the Java compiler source and target versions from 11 to 1.8 in the release-note-generation module. To maintain compatibility with Java 8, the code replaces InputStream.readAllBytes() with Guava's ByteStreams.toByteArray(). The review feedback suggests a more efficient alternative using CharStreams.toString with an InputStreamReader to avoid intermediate byte array allocations.
…eration TAG=agy CONV=f312eaf9-61ab-449f-868d-eae4d12a1830
lqiu96
enabled auto-merge (squash)
July 20, 2026 18:19
jinseopkim0
approved these changes
Jul 20, 2026
blakeli0
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the target version to 1.8 and replaces Java 9+ API usage.
Error:
from https://github.com/googleapis/google-cloud-java/actions/runs/29757930805/job/88405320844?pr=13799