Skip to content

fix(bom): make release-note-generation Java 8 compatible #13837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lqiu96 merged 4 commits into from
Jul 20, 2026
+7 −4
Merged

fix(bom): make release-note-generation Java 8 compatible #13837

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d014593
fix(bom): make release-note-generation Java 8 compatible
lqiu96 Jul 20, 2026
f884664
refactor(bom): import StandardCharsets in release-note-generation
lqiu96 Jul 20, 2026
6bf28e3
perf(bom): use CharStreams to read process output in release-note-gen…
lqiu96 Jul 20, 2026
2ac7911
Merge branch 'main' into fix_java8_class_version
lqiu96 Jul 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions java-cloud-bom/release-note-generation/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@

<properties>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<maven.compiler.source>11</maven.compiler.source>
<maven.compiler.target>11</maven.compiler.target>
<maven.compiler.source>1.8</maven.compiler.source>
<maven.compiler.target>1.8</maven.compiler.target>
<checkstyle.skip>true</checkstyle.skip>
</properties>

Expand Down
7 changes: 5 additions & 2 deletions ...oud-bom/release-note-generation/src/main/java/com/google/cloud/ReleaseNoteGeneration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,12 @@
import com.google.common.collect.Sets;
import com.google.common.collect.Sets.SetView;
import com.google.common.collect.Streams;
import com.google.common.io.CharStreams;
import com.google.common.io.Files;
import java.io.File;
import java.io.IOException;
import java.io.InputStreamReader;
import java.nio.charset.StandardCharsets;
import java.util.ArrayList;
import java.util.HashMap;
import java.util.List;
Expand Down Expand Up @@ -617,8 +620,8 @@ static String fetchReleaseNote(String owner, String repository, String tag)
builder.redirectErrorStream(true);
Process process = builder.start();
String output =
new String(
process.getInputStream().readAllBytes(), java.nio.charset.StandardCharsets.UTF_8);
CharStreams.toString(
new InputStreamReader(process.getInputStream(), StandardCharsets.UTF_8));
boolean finished = process.waitFor(1, TimeUnit.MINUTES);
Verify.verify(finished, "The process timed out");
Verify.verify(0 == process.exitValue(), "The command failed: %s", output);
Expand Down
Loading