chore(librarian): add tools section to librarian.yaml#17892
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds a tools section to librarian.yaml to specify pip dependencies and their versions, including gapic-generator, nox, ruff, isort, black, and synthtool. However, there are typos in the version numbers for nox (2025.11.12) and ruff (0.14.14) which do not exist on PyPI and will cause installation failures. These should be corrected to 2023.11.12 and 0.1.14 respectively.
hj690
changed the title
| googleapis: | ||
| commit: fe04226e3d76435acbfd3ffb51f6771740e1fb5b | ||
| sha256: e99c641a9c5525394de43c762b9db50c3ada1f219d6dbdba594ae992fbe1d838 | ||
| tools: |
There was a problem hiding this comment.
Should we include protoc and pandoc here as well?
Can we start using these tools right away? If not, please could you clarify which version of librarian will start using the tools here?
google-cloud-python/librarian.yaml
Line 15 in e70ab6f
There was a problem hiding this comment.
Should we include protoc and pandoc here as well?
That's a good question, I'll defer to @JoeWang1127 on this as I'm not sure if non-pip tools are already supported in tools section here.
Can we start using these tools right away? If not, please could you clarify which version of librarian will start using the tools here?
Not yet, the corresponding change in Librarian has landed but not released yet, the target version is v0.31.0, once released, I'll also send a message to your team channel to keep you informed.
There was a problem hiding this comment.
Just chatted with @JoeWang1127 offline, there's additional change needed to support protoc or pandoc, so we thought it's better to focus on pip in this PR for now.
|
Please could you resolve the conflict? |
|
Moving to draft since there is a file conflict. Please mark it as ready for review once it's fixed |
Sorry, GH was giving me a hard time this morning 😢 Now it seems back to normal and I just resolved the conflict. |
2 participants
Move Python tool installation list to librarian.yaml.
Note: this section is not consumed by Librarian yet, a follow up change to Librarian will be made to consume this setting.
For #6508