Skip to content

chore(librarian): add tools section to librarian.yaml #17892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hj690 merged 2 commits into from
Jul 24, 2026
+16 −0
Merged

chore(librarian): add tools section to librarian.yaml #17892

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0422a21
chore: add tools section to librarian.yaml
hj690 Jul 24, 2026
fb3e7c7
run Librarian tidy
hj690 Jul 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions librarian.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,22 @@ sources:
googleapis:
commit: ede8b2e652dc3716b544205ef772b39b86e3d2cb
sha256: 8f7c17af87f6215012010dddaffec3aa5df5668bf0def727577bc0bc6b698193
tools:

@parthea parthea Jul 24, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we include protoc and pandoc here as well?

https://github.com/googleapis/librarian/blob/baf9b8078c5e98cb90b53088f284fb7b060e195b/cmd/librarian/Dockerfile#L48-L52

Can we start using these tools right away? If not, please could you clarify which version of librarian will start using the tools here?

google-cloud-python/librarian.yaml

Line 15 in e70ab6f

version: v0.30.0

@hj690 hj690 Jul 24, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we include protoc and pandoc here as well?

That's a good question, I'll defer to @JoeWang1127 on this as I'm not sure if non-pip tools are already supported in tools section here.

Can we start using these tools right away? If not, please could you clarify which version of librarian will start using the tools here?

Not yet, the corresponding change in Librarian has landed but not released yet, the target version is v0.31.0, once released, I'll also send a message to your team channel to keep you informed.

@hj690 hj690 Jul 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just chatted with @JoeWang1127 offline, there's additional change needed to support protoc or pandoc, so we thought it's better to focus on pip in this PR for now.

pip:
- name: black
version: 23.7.0
package: black[jupyter]==23.7.0
- name: gapic-generator
version: 1.37.1
- name: isort
version: 5.11.0
- name: nox
version: 2025.11.12
- name: ruff
version: 0.14.14
- name: synthtool
version: e643ce8e20f8fe237a31a1754524ba987de72875
package: gcp-synthtool@git+https://github.com/googleapis/synthtool@e643ce8e20f8fe237a31a1754524ba987de72875
default:
output: packages
tag_format: '{name}-v{version}'
Expand Down
Loading