chore(PROC-1514): release v1.0.0 and remove release-as pin#99
Merged
Conversation
Remove the release-as: 1.0.0 pin from release-please-config.json so subsequent releases are derived from Conventional Commit types as intended. Includes a Release-As commit footer so release-please opens the 1.0.0 Release PR off this commit. Release-As: 1.0.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linear: https://linear.app/gradienthealth/issue/PROC-1514/adopt-release-please-for-cloud-optimized-dicom
Summary
Remove the
release-as: 1.0.0pin fromrelease-please-config.jsonso subsequent releases are derived from Conventional Commit types as intended. TheRelease-As: 1.0.0commit footer below forces release-please to open the 1.0.0 Release PR off this commit, since the previousci(PROC-1514):commit is non-user-facing and doesn't on its own trigger a release.Context
PR #97 wired up release-please but its merge commit was
ci:— release-please classifies that as non-user-facing and skipped opening a Release PR. Av1.0.0tag was cut manually, butpyproject.tomlwas still0.2.5at that commit, so the publish workflow built a0.2.5wheel that PyPI rejected (already existed). The tag has been deleted.This PR gets the release flowing correctly. Important: when squash-merging, keep the
Release-As: 1.0.0footer in the squash-commit message — release-please reads it from the commit onmain.Release-As: 1.0.0
Test plan
Release-As: 1.0.0footerv1.0.0tag created,pyproject.toml=1.0.0publish.ymlfires on tag → 1.0.0 wheel uploaded to PyPI