Skip to content

Move hackrf_core.x driver instances to drivers.x (2/3)#1709

Merged
mossmann merged 1 commit intogreatscottgadgets:mainfrom
antoinevg:antoinevg/refactor-hackrf-core-drivers
Apr 24, 2026
Merged

Move hackrf_core.x driver instances to drivers.x (2/3)#1709
mossmann merged 1 commit intogreatscottgadgets:mainfrom
antoinevg:antoinevg/refactor-hackrf-core-drivers

Conversation

@antoinevg
Copy link
Copy Markdown
Member

@antoinevg antoinevg commented Mar 31, 2026

Depends on #1705


@antoinevg antoinevg force-pushed the antoinevg/refactor-hackrf-core-drivers branch from 9de0e60 to d05de20 Compare March 31, 2026 09:34
@antoinevg antoinevg marked this pull request as ready for review March 31, 2026 11:53
This was referenced Apr 2, 2026
@antoinevg antoinevg force-pushed the antoinevg/refactor-hackrf-core-drivers branch from d05de20 to 7acb91f Compare April 2, 2026 07:39
@mossmann mossmann self-requested a review April 2, 2026 15:14
@antoinevg antoinevg force-pushed the antoinevg/refactor-hackrf-core-drivers branch 4 times, most recently from e570167 to 91c8646 Compare April 7, 2026 15:26
@antoinevg antoinevg changed the title Move hackrf_core.x driver instances to drivers.x Move hackrf_core.x driver instances to drivers.x (2/3) Apr 10, 2026
@antoinevg antoinevg force-pushed the antoinevg/refactor-hackrf-core-drivers branch from 91c8646 to 20864c0 Compare April 10, 2026 07:55
@antoinevg antoinevg marked this pull request as draft April 14, 2026 08:26
@antoinevg antoinevg force-pushed the antoinevg/refactor-hackrf-core-drivers branch 3 times, most recently from 1c53970 to b93b219 Compare April 22, 2026 11:55
@antoinevg antoinevg marked this pull request as ready for review April 22, 2026 12:59
@antoinevg antoinevg marked this pull request as draft April 23, 2026 14:10
@antoinevg antoinevg force-pushed the antoinevg/refactor-hackrf-core-drivers branch from b93b219 to 6d9622f Compare April 23, 2026 15:03
@antoinevg antoinevg marked this pull request as ready for review April 23, 2026 15:12
@antoinevg antoinevg force-pushed the antoinevg/refactor-hackrf-core-drivers branch from 6d9622f to adf83cb Compare April 24, 2026 07:17
Copy link
Copy Markdown
Member

@mossmann mossmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if these would be better in hackrf_usb.c or distributed through various source files instead of continuing to lump them together into a common .c file, but I'll let @martinling make that decision later if this doesn't work for his effort. I think this is fine for now.

@mossmann mossmann merged commit 60f7ccf into greatscottgadgets:main Apr 24, 2026
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants