Adding the isconsistent optional argument to interpolate functions#190
Conversation
* Removed the unneeded GridapDistributed. qualifier from some of the interpolate methods.
There was a problem hiding this comment.
Pull request overview
Adds an optional isconsistent argument to distributed interpolate* entry points so callers can control ghost-consistency handling when constructing the resulting FEFunction.
Changes:
- Extend
DistributedSingleFieldFESpaceinterpolate,interpolate!,interpolate_dirichlet*, andinterpolate_everywhere*to acceptisconsistent=false. - Thread
isconsistentthrough toFEFunction(...)constructors. - Document the API change in
NEWS.md.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
src/FESpaces.jl |
Adds isconsistent optional arg to distributed single-field interpolation functions and forwards it to FEFunction. |
NEWS.md |
Adds a changelog bullet for the new optional argument. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
(the isconsistent optional argument was missing)
….com:gridap/GridapDistributed.jl into adding_isconsistent_to_interpolate_functions
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #190 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 15 15
Lines 3998 3998
======================================
Misses 3998 3998
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
No description provided.