Skip to content

Adding the isconsistent optional argument to interpolate functions#190

Merged
amartinhuertas merged 5 commits intomasterfrom
adding_isconsistent_to_interpolate_functions
Feb 11, 2026
Merged

Adding the isconsistent optional argument to interpolate functions#190
amartinhuertas merged 5 commits intomasterfrom
adding_isconsistent_to_interpolate_functions

Conversation

@amartinhuertas
Copy link
Member

No description provided.

* Removed the unneeded GridapDistributed. qualifier from some of the
  interpolate methods.
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an optional isconsistent argument to distributed interpolate* entry points so callers can control ghost-consistency handling when constructing the resulting FEFunction.

Changes:

  • Extend DistributedSingleFieldFESpace interpolate, interpolate!, interpolate_dirichlet*, and interpolate_everywhere* to accept isconsistent=false.
  • Thread isconsistent through to FEFunction(...) constructors.
  • Document the API change in NEWS.md.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File Description
src/FESpaces.jl Adds isconsistent optional arg to distributed single-field interpolation functions and forwards it to FEFunction.
NEWS.md Adds a changelog bullet for the new optional argument.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

amartinhuertas and others added 3 commits February 11, 2026 14:48
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
(the isconsistent optional argument was missing)
….com:gridap/GridapDistributed.jl into adding_isconsistent_to_interpolate_functions
@codecov
Copy link

codecov bot commented Feb 11, 2026

Codecov Report

❌ Patch coverage is 0% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 0.00%. Comparing base (d0b4d9a) to head (5fed5d0).
⚠️ Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
src/FESpaces.jl 0.00% 18 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##           master    #190   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files          15      15           
  Lines        3998    3998           
======================================
  Misses       3998    3998           
Flag Coverage Δ
mpi 0.00% <0.00%> (ø)
sequential 0.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@amartinhuertas amartinhuertas merged commit 19056c6 into master Feb 11, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants