Skip to content

Adding the isconsistent optional argument to interpolate functions #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amartinhuertas merged 5 commits into from
Feb 11, 2026
Merged

Adding the isconsistent optional argument to interpolate functions #190

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d5acb15
Adding the isconsistent optional argument to interpolate functions
amartinhuertas Feb 11, 2026
7cbb0d7
* Updated NEWS with the proper PR number
amartinhuertas Feb 11, 2026
4ba7fc4
Update NEWS.md
amartinhuertas Feb 11, 2026
8841ef0
Fixed signature of interpolate! for the DistributedZeroMeanSpace case
amartinhuertas Feb 11, 2026
5fed5d0
Merge branch 'adding_isconsistent_to_interpolate_functions' of github…
amartinhuertas Feb 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

- New overloads for the `TrialFESpace` constructor where the data to be imposed is passed as a `DistributedCellField`. Since PR[#185](https://github.com/gridap/GridapDistributed.jl/pull/185).
- Added missing `FESpace` constructors for distributed triangulations specialized for the RT FEs case. Since PR[#188](https://github.com/gridap/GridapDistributed.jl/pull/188)
- Added optional argument `isconsistent` to interpolate functions. Since PR[#190](https://github.com/gridap/GridapDistributed.jl/pull/190).

## [0.4.10] - 2025-09-29

Expand Down
56 changes: 32 additions & 24 deletions src/FESpaces.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -456,77 +456,83 @@ function generate_gids(
generate_gids(cell_gids,cell_to_ldofs,nldofs)
end

function FESpaces.interpolate(u,f::DistributedSingleFieldFESpace)
function FESpaces.interpolate(u,f::DistributedSingleFieldFESpace, isconsistent=false)
free_values = zero_free_values(f)
interpolate!(u,free_values,f)
interpolate!(u,free_values,f,isconsistent)
end

function FESpaces.interpolate!(
u,free_values::AbstractVector,f::DistributedSingleFieldFESpace)
u,
free_values::AbstractVector,
f::DistributedSingleFieldFESpace,
isconsistent=false)
map(f.spaces,local_views(free_values)) do V,vec
interpolate!(u,vec,V)
end
FEFunction(f,free_values)
FEFunction(f,free_values,isconsistent)
end

function FESpaces.interpolate!(
u::DistributedCellField,free_values::AbstractVector,f::DistributedSingleFieldFESpace)
map(local_views(u),f.spaces,local_views(free_values)) do ui,V,vec
interpolate!(ui,vec,V)
u::DistributedCellField,
free_values::AbstractVector,
f::DistributedSingleFieldFESpace,
isconsistent=false)
map(local_views(u),f.spaces,local_views(free_values)) do u, V,vec
interpolate!(u,vec,V)
end
FEFunction(f,free_values)
FEFunction(f,free_values,isconsistent)
end

function FESpaces.interpolate_dirichlet(u, f::DistributedSingleFieldFESpace)
function FESpaces.interpolate_dirichlet(u, f::DistributedSingleFieldFESpace, isconsistent=false)
free_values = zero_free_values(f)
dirichlet_values = get_dirichlet_dof_values(f)
interpolate_dirichlet!(u,free_values,dirichlet_values,f)
interpolate_dirichlet!(u,free_values,dirichlet_values,f,isconsistent)
end

function FESpaces.interpolate_dirichlet!(
u, free_values::AbstractVector,
dirichlet_values::AbstractArray{<:AbstractVector},
f::DistributedSingleFieldFESpace)
f::DistributedSingleFieldFESpace, isconsistent=false)
map(f.spaces,local_views(free_values),dirichlet_values) do V,fvec,dvec
interpolate_dirichlet!(u,fvec,dvec,V)
end
FEFunction(f,free_values,dirichlet_values)
FEFunction(f,free_values,dirichlet_values,isconsistent)
end

function FESpaces.interpolate_dirichlet!(
u::DistributedCellField, free_values::AbstractVector,
dirichlet_values::AbstractArray{<:AbstractVector},
f::DistributedSingleFieldFESpace)
f::DistributedSingleFieldFESpace, isconsistent=false)
map(local_views(u), f.spaces,local_views(free_values),dirichlet_values) do u,V,fvec,dvec
interpolate_dirichlet!(u,fvec,dvec,V)
end
FEFunction(f,free_values,dirichlet_values)
FEFunction(f,free_values,dirichlet_values,isconsistent)
end

function FESpaces.interpolate_everywhere(u, f::DistributedSingleFieldFESpace)
function FESpaces.interpolate_everywhere(u, f::DistributedSingleFieldFESpace, isconsistent=false)
free_values = zero_free_values(f)
dirichlet_values = get_dirichlet_dof_values(f)
interpolate_everywhere!(u,free_values,dirichlet_values,f)
interpolate_everywhere!(u,free_values,dirichlet_values,f,isconsistent)
end

function FESpaces.interpolate_everywhere!(
u, free_values::AbstractVector,
dirichlet_values::AbstractArray{<:AbstractVector},
f::DistributedSingleFieldFESpace)
f::DistributedSingleFieldFESpace, isconsistent=false)
map(f.spaces,local_views(free_values),dirichlet_values) do V,fvec,dvec
interpolate_everywhere!(u,fvec,dvec,V)
end
FEFunction(f,free_values,dirichlet_values)
FEFunction(f,free_values,dirichlet_values,isconsistent)
end

function FESpaces.interpolate_everywhere!(
u::DistributedCellField, free_values::AbstractVector,
dirichlet_values::AbstractArray{<:AbstractVector},
f::DistributedSingleFieldFESpace)
f::DistributedSingleFieldFESpace, isconsistent=false)
map(local_views(u),f.spaces,local_views(free_values),dirichlet_values) do ui,V,fvec,dvec
interpolate_everywhere!(ui,fvec,dvec,V)
end
FEFunction(f,free_values,dirichlet_values)
FEFunction(f,free_values,dirichlet_values,isconsistent)
end

# Factories
Expand Down Expand Up @@ -877,13 +883,15 @@ end
# which does not properly interpolate the function provided.
# With this change, we are interpolating in the unconstrained space and then
# substracting the mean.
function FESpaces.interpolate!(u,free_values::AbstractVector,f::DistributedZeroMeanFESpace)
function FESpaces.interpolate!(u,free_values::AbstractVector,
f::DistributedZeroMeanFESpace, isconsistent=false)
dirichlet_values = get_dirichlet_dof_values(f)
interpolate_everywhere!(u,free_values,dirichlet_values,f)
interpolate_everywhere!(u,free_values,dirichlet_values,f,isconsistent)
end
function FESpaces.interpolate!(u::DistributedCellField,free_values::AbstractVector,f::DistributedZeroMeanFESpace)
function FESpaces.interpolate!(u::DistributedCellField,free_values::AbstractVector,
f::DistributedZeroMeanFESpace, isconsistent=false)
dirichlet_values = get_dirichlet_dof_values(f)
interpolate_everywhere!(u,free_values,dirichlet_values,f)
interpolate_everywhere!(u,free_values,dirichlet_values,f,isconsistent)
end

function _compute_new_distributed_fixedval(
Expand Down