fix(web): require auth for agent channel join and fix cert tests#3
Open
fix(web): require auth for agent channel join and fix cert tests#3
Conversation
gsmlg
force-pushed
the
fix/ci-compilation-and-tests
branch
from
aef916f to
94e2325
Compare
…tibility
- AgentChannel join/3 for specific agent channels now rejects
unauthenticated connections with {:error, %{reason: "unauthorized"}}
- Replace slow self-signed cert generation (RSA keygen) with lightweight
placeholder cert record when no CA available, preventing channel
handler timeouts during authentication
- Replace OpenSSL -not_before/-not_after flags (requires 3.2+) with
Erlang :public_key based certificate re-signing for validity tests
- Add rescue clause to issue_agent_certificate for robustness
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
gsmlg
force-pushed
the
fix/ci-compilation-and-tests
branch
from
94e2325 to
73806d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #2. Fixes the remaining 13 test failures in
secrethub_web:agent:<id>) with{:error, %{reason: "unauthorized"}}instead of auto-registering and authenticating (fixes 11 channel test failures)-not_before/-not_afterflags with Erlang:public_keybased certificate re-signing, compatible with all OpenSSL versions (fixes 2 cert test failures)Test plan
🤖 Generated with Claude Code