Splice export modifications precisely when using CPP#4981
Merged
Conversation
crtschin
force-pushed
the
crtschin/export-2-export-cpp
branch
2 times, most recently
from
4cdd6cf to
cd84c7c
Compare
crtschin
changed the title
fendor
approved these changes
Jun 20, 2026
fendor
left a comment
fendor
left a comment
Collaborator
There was a problem hiding this comment.
I reviewed the changes outside the hls-export-plugin, the tests look sane, please merge once you are ready or ping me on specific parts you want to discuss
crtschin
force-pushed
the
crtschin/export-2-export-cpp
branch
from
cd84c7c to
e5e4087
Compare
Collaborator
Author
|
Thanks! I think it's alright, none of this is complicated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on top of #4952 and handles CPP somewhat gracefully.
If possible, we stick with
ghc-exactprint. When we encounter a CPP directive in the export list, which is invisible toghc-exactprint, we fallback to using direct text splicing. In this case we only follow the active branch in the CPP conditional.A lot of this is tests... something about combinatorics and edgecases.