Skip to content

test(lsp): split diagnostics integration tests#3

Merged
t3chn merged 1 commit into
mainfrom
codex/split-lsp-smoke-tests
Jun 8, 2026
Merged

test(lsp): split diagnostics integration tests#3
t3chn merged 1 commit into
mainfrom
codex/split-lsp-smoke-tests

Conversation

@t3chn

@t3chn t3chn commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Move LSP diagnostics integration coverage into tests/lsp_diagnostics.rs.
  • Keep tests/smoke.rs focused on the broader smoke suite.
  • No runtime behavior changes.

Issue

  • N/A

Test plan

  • cargo test --test lsp_diagnostics
  • scripts/run-deterministic-tests.sh

Risks

  • narrow - test-only refactor; main risk is missed integration test discovery, covered by the deterministic test script.

Merge strategy recommendation

  • Recommended: squash
  • Reason: one logical hygiene change.

Why:
- Keep LSP diagnostics coverage isolated from the broad smoke suite.

What changed:
- Move direct, CLI, and eval LSP diagnostics tests into a dedicated integration test file.

Testing:
- cargo test --test lsp_diagnostics
- scripts/run-deterministic-tests.sh

Risk:
- narrow - test-only refactor with possible integration-test discovery changes.
@t3chn t3chn marked this pull request as ready for review June 8, 2026 10:33
@t3chn t3chn merged commit aff4b8b into main Jun 8, 2026
1 check passed
@t3chn t3chn deleted the codex/split-lsp-smoke-tests branch June 8, 2026 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant