Skip to content

test(lsp): split diagnostics integration tests #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
t3chn merged 1 commit into from
Jun 8, 2026
Merged

test(lsp): split diagnostics integration tests #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
165 changes: 165 additions & 0 deletions tests/lsp_diagnostics.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,165 @@
use code_intel_kernel::{
collect_rust_lsp_diagnostics_with_options, lsp_diagnostics_evidence_valid,
run_fixture_evaluation, LspAvailabilityStatus, LspDiagnosticsOptions, LspWarningCategory,
LSP_DIAGNOSTICS_CONTRACT_VERSION,
};
use serde_json::Value as JsonValue;
use std::process::Command;

#[test]
fn lsp_diagnostics_unavailable_when_rust_analyzer_is_missing() {
let report = collect_rust_lsp_diagnostics_with_options(
"tests/fixtures/rust-symbols-basic",
vec!["src/lib.rs".to_string()],
missing_rust_analyzer_options(),
);

assert_eq!(report.contract_version, LSP_DIAGNOSTICS_CONTRACT_VERSION);
assert_eq!(report.status, LspAvailabilityStatus::Unavailable);
assert!(report.diagnostics.is_empty());
assert!(report
.warnings
.iter()
.any(|warning| warning.category == LspWarningCategory::RustAnalyzerUnavailable));
assert!(report
.warnings
.iter()
.any(|warning| warning.category == LspWarningCategory::LspDiagnosticsUnavailable));
assert!(report
.missing_evidence
.iter()
.any(|item| item == "no_lsp_diagnostics"));
assert!(lsp_diagnostics_evidence_valid(&report));
}

#[test]
fn lsp_diagnostics_blocks_unsafe_or_unsupported_paths_before_server_start() {
let outside = collect_rust_lsp_diagnostics_with_options(
"tests/fixtures/rust-symbols-basic",
vec!["../Cargo.toml".to_string()],
missing_rust_analyzer_options(),
);
assert_eq!(outside.status, LspAvailabilityStatus::Error);
assert!(outside
.warnings
.iter()
.any(|warning| warning.category == LspWarningCategory::PathOutsideRepo));

let ignored = collect_rust_lsp_diagnostics_with_options(
"tests/fixtures/rust-symbols-basic",
vec!["target/generated.rs".to_string()],
missing_rust_analyzer_options(),
);
assert_eq!(ignored.status, LspAvailabilityStatus::Error);
assert!(ignored
.warnings
.iter()
.any(|warning| warning.category == LspWarningCategory::IgnoredPath));

let missing = collect_rust_lsp_diagnostics_with_options(
"tests/fixtures/rust-symbols-basic",
vec!["src/missing.rs".to_string()],
missing_rust_analyzer_options(),
);
assert_eq!(missing.status, LspAvailabilityStatus::Error);
assert!(missing
.warnings
.iter()
.any(|warning| warning.category == LspWarningCategory::MissingFile));
}

#[test]
fn lsp_diagnostics_output_is_deterministic_and_has_no_edit_target_language() {
let first = collect_rust_lsp_diagnostics_with_options(
"tests/fixtures/rust-symbols-basic",
vec!["src/lib.rs".to_string()],
missing_rust_analyzer_options(),
);
let second = collect_rust_lsp_diagnostics_with_options(
"tests/fixtures/rust-symbols-basic",
vec!["src/lib.rs".to_string()],
missing_rust_analyzer_options(),
);

let first_json = serde_json::to_value(&first).expect("LSP diagnostics should serialize");
let second_json = serde_json::to_value(&second).expect("LSP diagnostics should serialize");
assert_eq!(first_json, second_json);
assert_json_has_no_edit_target_language(&first_json);
}

#[test]
fn lsp_diagnostics_cli_output_is_valid_json_without_rust_analyzer() {
let binary = env!("CARGO_BIN_EXE_code-intel");
let output = Command::new(binary)
.env(
"CODE_INTEL_RUST_ANALYZER",
"code-intel-missing-rust-analyzer",
)
.args([
"lsp-diagnostics",
"--file",
"src/lib.rs",
"--timeout-ms",
"50",
"--json",
])
.output()
.expect("lsp-diagnostics command should run");
assert!(output.status.success());
let json: JsonValue =
serde_json::from_slice(&output.stdout).expect("lsp-diagnostics output should be JSON");
assert_eq!(json["contract_version"], LSP_DIAGNOSTICS_CONTRACT_VERSION);
assert_eq!(json["status"], "unavailable");
assert_json_has_no_edit_target_language(&json);
}

#[test]
fn lsp_diagnostics_eval_cases_pass() {
let report =
run_fixture_evaluation("tests/eval/cases").expect("eval report should include LSP cases");

for case_name in [
"lsp_diagnostics_unavailable",
"lsp_diagnostics_path_outside",
] {
let result = report
.cases
.iter()
.find(|case| case.name == case_name)
.expect("LSP diagnostics eval case should be present");
assert!(result.passed, "{case_name} failed: {:?}", result.failures);
}

let json = serde_json::to_value(&report).expect("eval report should serialize");
assert!(json["lsp_diagnostics_cases"]
.as_u64()
.is_some_and(|count| count >= 2));
}

fn missing_rust_analyzer_options() -> LspDiagnosticsOptions {
LspDiagnosticsOptions {
command: Some("code-intel-missing-rust-analyzer".to_string()),
timeout_ms: 50,
max_diagnostics: 16,
}
}

fn assert_json_has_no_edit_target_language(value: &JsonValue) {
let json = serde_json::to_string(value).expect("JSON value should serialize");
for forbidden in [
"edit this",
"edit here",
"target_edit",
"edit_location",
"patch target",
"apply patch",
"root cause",
"change this",
"correct edit location",
] {
assert!(
!json.contains(forbidden),
"runtime output should not contain edit-target phrase: {forbidden}"
);
}
}
153 changes: 7 additions & 146 deletions tests/smoke.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,16 @@
use code_intel_kernel::{
analyze_impact, build_source_context_report, build_source_evidence_bundle, build_symbol_graph,
collect_rust_lsp_diagnostics_with_options, create_evidence_bundle, evaluate_cases,
inspect_repo, load_eval_cases, lsp_diagnostics_evidence_valid, run_fixture_evaluation,
create_evidence_bundle, evaluate_cases, inspect_repo, load_eval_cases, run_fixture_evaluation,
source_context_evidence_valid, source_evidence_bundle_evidence_valid,
symbol_graph_evidence_valid, BundleConfidence, BundleStatus, BundleWarningCategory,
DetectionCategory, DetectionSeverity, EvalCase, EvalCaseKind, EvalExpect, EvidenceRequest,
ImpactConfidence, ImpactKind, ImpactReport, ImpactScope, ImpactStatus, KernelProfile,
LineRange, LspAvailabilityStatus, LspDiagnosticsOptions, LspWarningCategory, ParseStatus,
RelationshipKind, RepoContextRole, RepoInspection, SourceContextReport, SourceContextSelector,
SourceContextSelectorKind, SourceContextStatus, SourceContextWarningCategory,
SourceEvidenceBundle, SymbolGraph, SymbolKind, SymbolWarningCategory, EVAL_CONTRACT_VERSION,
IMPACT_CONTRACT_VERSION, INSPECT_CONTRACT_VERSION, LSP_DIAGNOSTICS_CONTRACT_VERSION,
SOURCE_CONTEXT_CONTRACT_VERSION, SOURCE_EVIDENCE_CONTRACT_VERSION, SYMBOLS_CONTRACT_VERSION,
LineRange, ParseStatus, RelationshipKind, RepoContextRole, RepoInspection, SourceContextReport,
SourceContextSelector, SourceContextSelectorKind, SourceContextStatus,
SourceContextWarningCategory, SourceEvidenceBundle, SymbolGraph, SymbolKind,
SymbolWarningCategory, EVAL_CONTRACT_VERSION, IMPACT_CONTRACT_VERSION,
INSPECT_CONTRACT_VERSION, SOURCE_CONTEXT_CONTRACT_VERSION, SOURCE_EVIDENCE_CONTRACT_VERSION,
SYMBOLS_CONTRACT_VERSION,
};
use serde_json::Value as JsonValue;
use std::process::Command;
Expand Down Expand Up @@ -783,113 +782,6 @@ fn where_to_edit_still_refuses_after_selector_hints_and_source_context() {
assert_json_has_no_edit_target_language(&json);
}

#[test]
fn lsp_diagnostics_unavailable_when_rust_analyzer_is_missing() {
let report = collect_rust_lsp_diagnostics_with_options(
"tests/fixtures/rust-symbols-basic",
vec!["src/lib.rs".to_string()],
missing_rust_analyzer_options(),
);

assert_eq!(report.contract_version, LSP_DIAGNOSTICS_CONTRACT_VERSION);
assert_eq!(report.status, LspAvailabilityStatus::Unavailable);
assert!(report.diagnostics.is_empty());
assert!(report
.warnings
.iter()
.any(|warning| warning.category == LspWarningCategory::RustAnalyzerUnavailable));
assert!(report
.warnings
.iter()
.any(|warning| warning.category == LspWarningCategory::LspDiagnosticsUnavailable));
assert!(report
.missing_evidence
.iter()
.any(|item| item == "no_lsp_diagnostics"));
assert!(lsp_diagnostics_evidence_valid(&report));
}

#[test]
fn lsp_diagnostics_blocks_unsafe_or_unsupported_paths_before_server_start() {
let outside = collect_rust_lsp_diagnostics_with_options(
"tests/fixtures/rust-symbols-basic",
vec!["../Cargo.toml".to_string()],
missing_rust_analyzer_options(),
);
assert_eq!(outside.status, LspAvailabilityStatus::Error);
assert!(outside
.warnings
.iter()
.any(|warning| warning.category == LspWarningCategory::PathOutsideRepo));

let ignored = collect_rust_lsp_diagnostics_with_options(
"tests/fixtures/rust-symbols-basic",
vec!["target/generated.rs".to_string()],
missing_rust_analyzer_options(),
);
assert_eq!(ignored.status, LspAvailabilityStatus::Error);
assert!(ignored
.warnings
.iter()
.any(|warning| warning.category == LspWarningCategory::IgnoredPath));

let missing = collect_rust_lsp_diagnostics_with_options(
"tests/fixtures/rust-symbols-basic",
vec!["src/missing.rs".to_string()],
missing_rust_analyzer_options(),
);
assert_eq!(missing.status, LspAvailabilityStatus::Error);
assert!(missing
.warnings
.iter()
.any(|warning| warning.category == LspWarningCategory::MissingFile));
}

#[test]
fn lsp_diagnostics_output_is_deterministic_and_has_no_edit_target_language() {
let first = collect_rust_lsp_diagnostics_with_options(
"tests/fixtures/rust-symbols-basic",
vec!["src/lib.rs".to_string()],
missing_rust_analyzer_options(),
);
let second = collect_rust_lsp_diagnostics_with_options(
"tests/fixtures/rust-symbols-basic",
vec!["src/lib.rs".to_string()],
missing_rust_analyzer_options(),
);

let first_json = serde_json::to_value(&first).expect("LSP diagnostics should serialize");
let second_json = serde_json::to_value(&second).expect("LSP diagnostics should serialize");
assert_eq!(first_json, second_json);
assert_json_has_no_edit_target_language(&first_json);
}

#[test]
fn lsp_diagnostics_cli_output_is_valid_json_without_rust_analyzer() {
let binary = env!("CARGO_BIN_EXE_code-intel");
let output = Command::new(binary)
.env(
"CODE_INTEL_RUST_ANALYZER",
"code-intel-missing-rust-analyzer",
)
.args([
"lsp-diagnostics",
"--file",
"src/lib.rs",
"--timeout-ms",
"50",
"--json",
])
.output()
.expect("lsp-diagnostics command should run");
assert!(output.status.success());
let json: JsonValue =
serde_json::from_slice(&output.stdout).expect("lsp-diagnostics output should be JSON");
assert_eq!(json["contract_version"], LSP_DIAGNOSTICS_CONTRACT_VERSION);
assert_eq!(json["status"], "unavailable");
assert_json_has_no_edit_target_language(&json);
}

#[test]
fn symbol_graph_extracts_top_level_rust_symbols() {
let graph = build_symbol_graph("tests/fixtures/rust-symbols-basic");
Expand Down Expand Up @@ -1485,14 +1377,6 @@ fn source_context_cli_output_is_valid_json() {
.any(|slice| slice.file_path == "src/lib.rs"));
}

fn missing_rust_analyzer_options() -> LspDiagnosticsOptions {
LspDiagnosticsOptions {
command: Some("code-intel-missing-rust-analyzer".to_string()),
timeout_ms: 50,
max_diagnostics: 16,
}
}

fn assert_json_has_no_edit_target_language(value: &JsonValue) {
let json = serde_json::to_string(value).expect("JSON value should serialize");
for forbidden in [
Expand Down Expand Up @@ -1674,29 +1558,6 @@ fn source_context_eval_cases_pass() {
}
}

#[test]
fn lsp_diagnostics_eval_cases_pass() {
let report =
run_fixture_evaluation("tests/eval/cases").expect("eval report should include LSP cases");

for case_name in [
"lsp_diagnostics_unavailable",
"lsp_diagnostics_path_outside",
] {
let result = report
.cases
.iter()
.find(|case| case.name == case_name)
.expect("LSP diagnostics eval case should be present");
assert!(result.passed, "{case_name} failed: {:?}", result.failures);
}

let json = serde_json::to_value(&report).expect("eval report should serialize");
assert!(json["lsp_diagnostics_cases"]
.as_u64()
.is_some_and(|count| count >= 2));
}

#[test]
fn adversarial_localization_eval_cases_pass() {
let report = run_fixture_evaluation("tests/eval/cases").expect("eval report should run");
Expand Down
Loading