patch geeglm() error when starting values specified#18
Open
jeffeaton wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR patches issue #5 that
geeglm()threw an error when argumentstart =was specified.I also suggested one other small change. For the starting values of
geese.fit(), I removed the condition:So that it instead always uses the coefficients from
glmFitas the starting values forgeese.fit()The specified starting values are still used as starting values for the initial
glm()fit.Maybe I am missing something though about why it reverts back to the initial starting values for initialising
geese.fit().Thanks,
Jeff