Skip to content

patch geeglm() error when starting values specified #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jeffeaton wants to merge 1 commit into
base: master
Choose a base branch
from
Open

patch geeglm() error when starting values specified #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DESCRIPTION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
Package: geepack
Version: 1.3.9
Version: 1.3.10
Title: Generalized Estimating Equation Package
Authors@R: c(
person(given = "Søren", family = "Højsgaard",
Expand Down
4 changes: 4 additions & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
# geepack v1.3.10 (2022-09-27)

* Patch `geeglm()` error when specifying starting values (issue #5).

# geepack v1.3.9 (2022-08-16)

* QIC now takes environment argument because the function is called from another function in another package.
Expand Down
12 changes: 9 additions & 3 deletions R/geeglm.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,8 @@ geeglm<- function (formula, family = gaussian, data = parent.frame(),
mf[[1]] <- as.name("model.frame")

mftmp <- mf
to_delete <- c("family", "corstr", "control", "zcor", "std.err", "scale.fix")
to_delete <- c("family", "corstr", "control", "zcor", "std.err", "scale.fix",
"start", "etastart", "mustart")
mftmp[match(to_delete, names(mftmp))] <- NULL

## mftmp$family <- mftmp$corstr <- mftmp$control <- mftmp$zcor <- mftmp$std.err <- NULL
Expand Down Expand Up @@ -249,9 +250,14 @@ geeglm<- function (formula, family = gaussian, data = parent.frame(),
xx <- as.data.frame(xx)
xx[, nacoef] <- NULL
xx <- as.matrix(xx)

## @jeffeaton 2022-09-27: I am not sure if this if(is.null(start)) is desireable.
## The specified starting values will be used in the initial glm() fit to create
## glmFit. But here it seems better to use the glmFit coefficients.
##
## if (is.null(start))

if (is.null(start))
start <- glmFit$coef
start <- glmFit$coef

ans <- geese.fit(xx, yy, id, offset, soffset, w, waves = waves,
zsca, zcor = zcor, corp = NULL, control = control, b = start,
Expand Down