[builder] feat: implement upstream field for build.toml.#379
Open
[builder] feat: implement upstream field for build.toml.#379
Conversation
danieldk
reviewed
Mar 19, 2026
sayakpaul
commented
Mar 19, 2026
kernel-builder/src/config/compat.rs
Outdated
| V1(v1::Build), | ||
| V2(v2::Build), | ||
| V3(v3::Build), | ||
| V3(Box<v3::Build>), |
Member
Author
There was a problem hiding this comment.
Otherwise https://github.com/huggingface/kernels/actions/runs/23290500058/job/67724598491?pr=379. Any better way?
Member
There was a problem hiding this comment.
I would just use #[allow(clippy::large_enum_variant)] on the enum. This isn't performance-sensitive code and having a Box in between is annoying.
Member
Author
|
@danieldk thanks for the tidbits! I think it's very cool that it warned me about a memory increase for a different type. Still lots to learn but please keep these golden suggestions coming! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to huggingface/kernel-builder#343