Explicitly acknowledge _missing_ override in UnknownEnumMixin#1929
Merged
Explicitly acknowledge _missing_ override in UnknownEnumMixin#1929
Conversation
… override Co-authored-by: iMicknl <1424596+iMicknl@users.noreply.github.com>
Co-authored-by: iMicknl <1424596+iMicknl@users.noreply.github.com>
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] Update enum structure based on feedback
Explicitly acknowledge _missing_ override in UnknownEnumMixin
Jan 28, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves type checker clarity for the UnknownEnumMixin._missing_ method by explicitly acknowledging its intentional override of the base enum _missing_ method. The change addresses type checker ambiguity in mixin patterns where the @override decorator cannot be used.
Changes:
- Added
# type: ignore[override]annotation to_missing_method to silence type checker warnings about override in mixin pattern - Enhanced docstring to document the intentional override behavior
- Removed unused
Anyimport from typing module
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
UnknownEnumMixin._missing_method overridesStrEnum._missing_but lacked explicit acknowledgment, causing type checker ambiguity about the intentional override in the mixin pattern.Changes
# type: ignore[override]to_missing_method signatureStrEnum._missing_AnyimportContext
Mixin classes can't use
@overridedecorator since they don't directly inherit from the classes they'll be mixed with. The type ignore annotation is the standard pattern for acknowledging overrides in mixins.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.