Skip to content

Explicitly acknowledge _missing_ override in UnknownEnumMixin #1929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iMicknl merged 4 commits into from
Jan 29, 2026
Merged

Explicitly acknowledge _missing_ override in UnknownEnumMixin #1929

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ffcd8af
Initial plan
Copilot Jan 28, 2026
b39581b
Add type: ignore[override] to explicitly acknowledge _missing_ method…
Copilot Jan 28, 2026
3288d73
Fix trailing whitespace in docstring
Copilot Jan 28, 2026
4e52c10
Update pyoverkiz/enums/base.py
iMicknl Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions pyoverkiz/enums/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
from __future__ import annotations

import logging
from typing import Any, Self, cast
from typing import Self, cast


class UnknownEnumMixin:
Expand All @@ -16,8 +16,11 @@ class UnknownEnumMixin:
__missing_message__ = "Unsupported value %s has been returned for %s"

@classmethod
def _missing_(cls, value: object) -> Self:
"""Return `UNKNOWN` and log unrecognized values."""
def _missing_(cls, value: object) -> Self: # type: ignore[override]
"""Return `UNKNOWN` and log unrecognized values.

Intentionally overrides the Enum base `_missing_` to provide an UNKNOWN fallback.
"""
message = cls.__missing_message__
logging.getLogger(cls.__module__).warning(message, value, cls)
# Type checker cannot infer UNKNOWN exists on Self, but all subclasses define it
Expand Down