Open
Conversation
nikolaydubina
suggested changes
Feb 17, 2025
| @@ -1,9 +1,120 @@ | |||
| dmitri.shuralyov.com/gpu/mtl v0.0.0-20190408044501-666a987793e9/go.mod h1:H6x//7gZCb22OMCxBHrMx7a5I7Hp++hsVxbQ4BYO7hU= | |||
|
Hey 👋🏻 We quickly hit this panic when running on ARM-based VMs, rendering the module unusable. Is there a reason this is not being merged? |
josephschorr
pushed a commit
to authzed/spicedb
that referenced
this pull request
Mar 24, 2025
vendors influxdata/tdigest#32 for the purpose of validating the functionality without the panic. We will likely follow up by replacing the library as this tdigest does not seem to be maintained anymore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22.
(*TDigest).Quantile()causes an OOB panic when the digest has been provided with values that, due to floating point arithmetic errors, cause thesort.Searchcall to not find anisuch thatt.cumulative[i] >= index. (Minimal playground reproduction). This PR fixes this bug by clamping access toprocessed.Len().Furthermore, the unit tests as written did not pass on my M2 MacBook Pro: due to differences in how the M2 performs floating point math compared to Intel or AMD CPUs, there are small deltas some 14 digits into the results, so
got == tt.expectedevaluates to false:This PR fixes tests on this hardware by updating to a more recent version of gonum and using its
scalar.EqualWithinRelfunction to compare floats.