Issue28: Updated DNS record to exclude name_in_zone in this scenario#33
Closed
rsingh4infoblox wants to merge 2 commits into
Closed
Issue28: Updated DNS record to exclude name_in_zone in this scenario#33rsingh4infoblox wants to merge 2 commits into
rsingh4infoblox wants to merge 2 commits into
Conversation
unasra
reviewed
Jun 3, 2026
| "additional_properties", | ||
| ]) | ||
|
|
||
| # Exclude name_in_zone when absolute_name_spec and view are provided |
Collaborator
There was a problem hiding this comment.
This is an autogenerated file . It cant be modified manually !
Next time this file generatedby the generator , these changes would be overwritten
Collaborator
There was a problem hiding this comment.
We have to find some other work around , as we cannot change default for name_in_zone back to None as it is vital to creating a zone without a name !
unasra
reviewed
Jun 9, 2026
Author
|
#37 - new. pr opened |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a conditional exclusion for the
name_in_zonefield in theto_dictmethod of theRecordmodel. When bothabsolute_name_specandvieware set andname_in_zoneis empty, the field will be omitted from the serialized output.Serialization logic update:
to_dictmethod insrc/dns_data/models/record.pyto exclude thename_in_zonefield whenabsolute_name_specandvieware provided andname_in_zoneis an empty string.