Skip to content

Issue28: Updated DNS record to exclude name_in_zone in this scenario #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rsingh4infoblox wants to merge 2 commits into from
+2 −3
Closed

Issue28: Updated DNS record to exclude name_in_zone in this scenario #33

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6f2816e
Issue28: Updated DNS record to exclude name_in_zone in this scenario
rsingh4infoblox May 25, 2026
d3952a7
Updated name_in_zone
rsingh4infoblox Jun 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/dns_data/models/record.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ class Record(BaseModel):
ipam_host: Optional[StrictStr] = Field(
default=None, description="The resource identifier.")
name_in_zone: Optional[StrictStr] = Field(
default='',
default=None,
Comment thread
rsingh4infoblox marked this conversation as resolved.
description=
"The relative owner name to the zone origin. Must be specified for creating the DNS resource record and is read only for other operations."
)
Expand Down Expand Up @@ -256,8 +256,7 @@ def from_dict(cls, obj: Optional[Dict[str, Any]]) -> Optional[Self]:
"ipam_host":
obj.get("ipam_host"),
"name_in_zone":
obj.get("name_in_zone")
if obj.get("name_in_zone") is not None else '',
obj.get("name_in_zone"),
"options":
obj.get("options"),
"provider_metadata":
Expand Down
Loading