Avoid xarray to cast ints to float64 just to add a NaN#27
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to prevent xarray from decoding integer river maps into float64 (to represent missing values as NaN) when generating OB indices, reducing unnecessary dtype changes and associated overhead.
Changes:
- Adjust
xarray.open_datasetusage for reading theriversvariable to disable masking/scaling. - Update a debug log message in OB indices generation.
- Reduce logging noise by raising the
numbalogger level.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/mitgcm_inputs/ob_indices/ob_indices.py |
Tweaks a debug log message emitted during boundary strip extraction. |
src/mitgcm_inputs/ob_indices/__init__.py |
Changes how the rivers dataset is opened to avoid xarray masking/scaling behavior. |
src/mitgcm_inputs/__main__.py |
Adds numba to the list of loggers whose verbosity is reduced. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.