Skip to content

Avoid xarray to cast ints to float64 just to add a NaN #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
spiani merged 1 commit into from
Apr 22, 2026
Merged

Avoid xarray to cast ints to float64 just to add a NaN #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/mitgcm_inputs/__main__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ def configure_logger():
copernicusmarine_logger.handlers.clear()

# Avoid too much noise from botocore and urllib3 when in DEBUG mode
logging.getLogger("numba").setLevel(logging.INFO)
logging.getLogger("botocore").setLevel(logging.INFO)
logging.getLogger("findlibs").setLevel(logging.INFO)
logging.getLogger("urllib3").setLevel(logging.ERROR)
Expand Down
4 changes: 3 additions & 1 deletion src/mitgcm_inputs/ob_indices/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,9 @@ def main(args: argparse.Namespace) -> int:

# If there are rivers in this domain
if args.rivers_positions is not None:
with xr.open_dataset(file_with_river) as river_ds:
with xr.open_dataset(
file_with_river, mask_and_scale=False
) as river_ds:
river_map = river_ds["rivers"].load()
Comment thread
spiani marked this conversation as resolved.

river_mask = MaskWithRivers(
Expand Down
2 changes: 1 addition & 1 deletion src/mitgcm_inputs/ob_indices/ob_indices.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ def generate_ob_indices(
# boundary
closed_cell = 0

LOGGER.debug("Cutting %i cells from the %s", cut_cells, side)
LOGGER.debug("Reading %i cells from the %s", cut_cells, side)
Comment thread
spiani marked this conversation as resolved.
current_side = cut_at_side(mask.get_sea_cells(), side, cut_cells)

# We only take into account the surface
Expand Down