feat(plot): improve topic auto-detect, TF support, and chart UX.#15
Merged
Merged
Conversation
Make Plot easier to use for multi-type ROS data by fixing path detection, supporting TFMessage, and adding zoom, reset, and inline legend controls.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make Plot easier to use for multi-type ROS data by fixing path detection, supporting TFMessage, and adding zoom, reset, and inline legend controls.
Description
This PR upgrades the Plot panel for multi-type ROS data and better in-chart interaction:
jointStateFieldsoverriding non-JointStatetopics (e.g.PoseStampedno longer defaults toposition[:])fieldDiscovery.ts) and a topic field tree in settingsplotTopicService(comma-separated defaults)tf2_msgs/TFMessagewith a dedicated adaptertransforms[:].transform.translation.x/y/zwith stable keys/labels viachild_frame_idJointStateand similar topicsShift→ Y;Ctrl/Meta→ X+YresetViewportAPIPlotChartLegendoverlay (top-left, collapsed by default)w-80) to avoid layout jump; collapsed view prefers currently visible series after Onlyen/zh/japanels.jsonstrings for reset zoom, legend, and topic fieldsMotivation / related issue
Plot previously struggled with non-
JointStatemessage types, showed blank charts for/tf(TFMessage), and lacked Foxglove-like zoom/pan/reset and an in-chart legend. This change makes common ROS workflows work out of the box andimproves day-to-day chart usability.
Type of change
Checklist
npm run lintpasses with no errorsnpm testpasses (unit tests; Plot suite ~140 cases)npm run buildandnpm run build:libsucceedAPI compatibility
N/A — changes are confined to the Plot panel and related i18n strings; no exported public API changes.
Screenshots / recordings
Recommended before merge:
PoseStamped/JointStateauto-detected paths/tfshowing per-child_frame_idtranslation series