Skip to content

Polish: #11 review leftovers (closes #23)#31

Merged
irobinson010 merged 1 commit into
feature/gui-mp4from
feature/23-polish
Jul 8, 2026
Merged

Polish: #11 review leftovers (closes #23)#31
irobinson010 merged 1 commit into
feature/gui-mp4from
feature/23-polish

Conversation

@irobinson010

Copy link
Copy Markdown
Owner

Summary

Closes #23 — the three consciously-deferred items from the #11 review:

  • HTML player head-color drift: drop heads now brightness-track exactly like the ANSI and GIF sinks (16 .hN classes computed with the shared _cell_rgb blend) instead of a fixed full-bright color.
  • Floyd–Steinberg at width: the serial inner loop runs on Python lists rather than per-element NumPy indexing — 3.5× faster (0.69s → 0.20s at 1200×800, i.e. ~400-col braille), with float64 accumulation.
  • Loop seam: documented — drop positions loop seamlessly, glyph identities re-roll at the wrap (reads as the rain's normal flicker, per the review's own measurement).

Stacked on #30 (end of the current chain: #27#29#30 → this).

Test plan

  • 191 tests pass (head-color test updated to the brightness-tracked classes)
  • Dither rewrite benchmarked and cross-checked against the previous implementation (98.6% dot agreement on random noise; differences are float64-vs-float32 rounding on borderline pixels)
  • CI matrix green

🤖 Generated with Claude Code

- HTML player drop heads brightness-track like the ANSI/GIF sinks: 16
  .hN classes computed with the same _cell_rgb blend, replacing the fixed
  full-bright head color.
- Floyd-Steinberg dither inner loop runs on Python lists instead of
  per-element NumPy indexing: 3.5x faster at cols~400 (0.69s -> 0.20s on
  1200x800), float64 accumulation (slightly more accurate on borderline
  pixels).
- README documents the loop-seam behavior: drop positions loop
  seamlessly, glyph identities re-roll at the wrap.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@irobinson010
irobinson010 requested a review from krakenhavoc July 7, 2026 15:17
@irobinson010
irobinson010 merged commit 4d7cf26 into feature/gui-mp4 Jul 8, 2026
6 checks passed
@irobinson010
irobinson010 deleted the feature/23-polish branch July 8, 2026 14:43
irobinson010 added a commit that referenced this pull request Jul 8, 2026
GUI mp4 download + #11 review polish (reopens #30, #31)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant