ObjectPlacer: reject overlapping placements#439
Merged
cvolkcvolk merged 3 commits intomainfrom Feb 26, 2026
Merged
Conversation
alexmillane
reviewed
Feb 26, 2026
Collaborator
alexmillane
left a comment
alexmillane
left a comment
There was a problem hiding this comment.
I have a question about why we're using 2D overlaps. Is there a reason not to go with 3D? Maybe there's a good reason though.
cvolkcvolk
changed the title
alexmillane
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_validate_placementwas a stub that always returned True, so the solver could converge to solutions where objects overlap_validate_placementin ObjectPlacer to detect bounding-box overlaps between placed objects, causing the placer to retry again.