Adds Unit Tests for NewtonWarpRenderer#4703
Open
daniela-hase wants to merge 2 commits intoisaac-sim:developfrom
Open
Adds Unit Tests for NewtonWarpRenderer#4703daniela-hase wants to merge 2 commits intoisaac-sim:developfrom
daniela-hase wants to merge 2 commits intoisaac-sim:developfrom
Conversation
Contributor
Greptile SummaryThis PR contains bug fixes for the Newton Warp Renderer that enable unit tests to pass. Changes:
Note: Despite the PR title "Added Unit Tests for NewtonWarpRenderer", no new test files were added in this PR. The changes fix issues that were preventing existing tests from passing. Confidence Score: 5/5
Important Files Changed
Last reviewed commit: de26f15 |
kellyguo11
reviewed
Feb 24, 2026
| """Use CUDA if available, else skip.""" | ||
| if not torch.cuda.is_available(): | ||
| pytest.skip("CUDA not available") | ||
| return "cuda:0" |
Contributor
There was a problem hiding this comment.
does the newton renderer work on CPU as well?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added Unit Tests for NewtonWarpRenderer
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there