[Newton] Implements FrameTransformer Sensor via SensorFrameTransform#4709
Draft
camevor wants to merge 9 commits intoisaac-sim:dev/newtonfrom
Draft
[Newton] Implements FrameTransformer Sensor via SensorFrameTransform#4709camevor wants to merge 9 commits intoisaac-sim:dev/newtonfrom
SensorFrameTransform#4709camevor wants to merge 9 commits intoisaac-sim:dev/newtonfrom
Conversation
- Extract NewtonContactSensorCfg into its own file with shape-level fields (sensor_shape_prim_expr, filter_shape_prim_expr), sensor_body_prim_expr property alias, from_base_cfg factory, and __post_init__ guards for unsupported options - Rename base ContactSensorCfg fields: filter_prim_paths_expr → filter_body_prim_expr, drop shape_path and filter_shape_paths_expr (moved to Newton subclass) - Resolve regex expressions to list[int] indices in add_contact_sensor via resolve_matching_names, removing flipped_match / match_fn - Simplify ContactSensor._initialize_impl — pass cfg fields directly instead of building joined regex strings - Update interactive_scene.py env-regex expansion to use renamed fields - Update docstring references in contact_sensor_data.py
camevor
force-pushed
the
ca/frame-transform-sensor
branch
from
850a6d2 to
450110e
Compare
camevor
changed the title
SensorFrameTransform
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Screenshots
Please attach before and after screenshots of the change if applicable.
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there