Adds assertions for shapes on the asset APIs.#4719
Open
AntoineRichard wants to merge 13 commits intoisaac-sim:developfrom
Open
Adds assertions for shapes on the asset APIs.#4719AntoineRichard wants to merge 13 commits intoisaac-sim:developfrom
AntoineRichard wants to merge 13 commits intoisaac-sim:developfrom
Conversation
Contributor
Greptile SummaryThis PR adds optional runtime validation for shape and dtype of inputs to asset APIs across the IsaacLab codebase. Key Changes:
Benefits:
Confidence Score: 5/5
Important Files Changed
Last reviewed commit: 321c578 |
ooctipus
approved these changes
Feb 25, 2026
kellyguo11
reviewed
Feb 26, 2026
Contributor
|
test failure that looks related to these changes |
kellyguo11
approved these changes
Feb 26, 2026
31fbcff to
c568ad8
Compare
Signed-off-by: Kelly Guo <kellyg@nvidia.com>
Signed-off-by: Kelly Guo <kellyg@nvidia.com>
c568ad8 to
4b00ea8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds an optional check to validate the shapes and dtype of the inputs fed into the asset API.
Type of change
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there