IsaacLab 3.0 Locomanipulation SDG support#4725
Open
jaybdub wants to merge 7 commits intoisaac-sim:developfrom
Open
IsaacLab 3.0 Locomanipulation SDG support#4725jaybdub wants to merge 7 commits intoisaac-sim:developfrom
jaybdub wants to merge 7 commits intoisaac-sim:developfrom
Conversation
Contributor
Greptile SummaryThis PR fixes Isaac Lab 3.0 compatibility issues in the locomanipulation SDG workflow by addressing CUDA device placement and quaternion convention changes. Key changes:
Confidence Score: 5/5
Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Dataset Loading] --> B{Legacy Quat Format?}
B -->|Yes| C[Convert WXYZ to XYZW]
B -->|No| D[Use XYZW directly]
C --> E[Episode Data]
D --> E
E --> F[Scene Reset]
F --> G[Clone State Tensors]
G --> H[Apply .to device]
H --> I[Warp to Torch Conversion]
I --> J[Transform Operations]
J --> K[Device-aware Tensor Creation]
K --> L[Locomanipulation SDG]
Last reviewed commit: 812a3fb |
76d7fc0 to
5905bdb
Compare
peterd-NV
reviewed
Feb 25, 2026
Contributor
peterd-NV
left a comment
There was a problem hiding this comment.
Following the slack on thread, can the dataset download links be updated to content-staging and 6.0
7 tasks
|
Could you please open access to ONNX in this repository: https://github.com/NVIDIA-AI-IOT/sdg_pallet_model People have requested access, but nobody has received it according to the GitHub issues. Thanks in advance! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR (implemented by Yuchen Deng / Chirag Majithia) handles quat conversion in the locomanipulation SDG workflow, enabling support for Isaac Lab 3.0. This also updates the documentation to add the
--visualizer kitcommand required to run the workflow.Locomanipulation SDG was broken with Isaac Lab 3.0+ due to CUDA device semantics / quaternion conversion. This is fixed by this PR.
Type of change
Screenshots
Please attach before and after screenshots of the change if applicable.
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there