Fixes cloner to skip cloning the source environment.#4731
Open
ooctipus wants to merge 2 commits intoisaac-sim:developfrom
Open
Fixes cloner to skip cloning the source environment.#4731ooctipus wants to merge 2 commits intoisaac-sim:developfrom
ooctipus wants to merge 2 commits intoisaac-sim:developfrom
Conversation
84cbd3f to
01f0449
Compare
Contributor
Greptile SummaryThis PR fixes a critical bug where cloning environments could cause self-replication when the source environment path matches a destination path. The fix prevents Key Changes:
The implementation is clean, well-tested, and follows semantic versioning conventions. Confidence Score: 5/5
Important Files Changed
Last reviewed commit: 01f0449 |
3626bfe to
d4a814f
Compare
d4a814f to
439e197
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Cloning the source environment can leads to some unexpected bug, this PR skips the cloning source environment during usd_replicate and physx_replicate
Type of change
Screenshots
Please attach before and after screenshots of the change if applicable.
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there