Skip to content

update newton pin#4737

Open
matthewtrepte wants to merge 1 commit intoisaac-sim:developfrom
matthewtrepte:mtrepte/update_newton_version
Open

update newton pin#4737
matthewtrepte wants to merge 1 commit intoisaac-sim:developfrom
matthewtrepte:mtrepte/update_newton_version

Conversation

@matthewtrepte
Copy link
Contributor

Description

Update Newton Version to fix a regression in the Rerun Visualizer. Note, a newton version update is also required in Isaac Sim, tracked in this change - https://gitlab-master.nvidia.com/omniverse/isaac/omni_isaac_sim/-/merge_requests/7685

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Screenshots

Please attach before and after screenshots of the change if applicable.

Checklist

  • I have read and understood the contribution guidelines
  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

@github-actions github-actions bot added the isaac-lab Related to Isaac Lab team label Feb 26, 2026
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 26, 2026

Greptile Summary

Updates the Newton package dependency from commit 35657fc to 821d4daafa2df446f6300688ba6a8a1d15e19e36 to fix a regression in the Rerun Visualizer.

  • Simple dependency version update that changes a single line in setup.py
  • Uses full 40-character commit hash instead of shortened 7-character version (both formats are valid)
  • Requires coordinated update in Isaac Sim (tracked separately per PR description)

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • The change is a straightforward dependency version update with a single line modified. The syntax is correct, and the change addresses a documented regression in the Rerun Visualizer. No code logic or breaking changes are introduced.
  • No files require special attention

Important Files Changed

Filename Overview
source/isaaclab/setup.py Updated Newton dependency pin from short commit hash to full SHA to fix Rerun Visualizer regression

Last reviewed commit: a1b3c2d

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need the newton dep here?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure the newton dep in isaaclab_newton is matching that one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

isaac-lab Related to Isaac Lab team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants