Aligns mimic and pink files structures to rest of IsaacLab#4740
Draft
ooctipus wants to merge 2 commits intoisaac-sim:developfrom
Draft
Aligns mimic and pink files structures to rest of IsaacLab#4740ooctipus wants to merge 2 commits intoisaac-sim:developfrom
ooctipus wants to merge 2 commits intoisaac-sim:developfrom
Conversation
github-actions
bot
added
bug
ooctipus
changed the title
ooctipus
force-pushed
the
fix/develop/cleanup_pink_mimic
branch
from
b980728 to
64db653
Compare
ooctipus
force-pushed
the
fix/develop/cleanup_pink_mimic
branch
from
64db653 to
8fe61aa
Compare
Collaborator
AntoineRichard
left a comment
AntoineRichard
left a comment
There was a problem hiding this comment.
This looks like it brings a bunch of breaking changes around pink. That might be needed, I can't tell.
Comment on lines
+113
to
+122
| _teleop_pkg_dir = os.path.dirname(_teleop_cfg_file) | ||
| _data_dir = os.path.join( | ||
| _teleop_pkg_dir, | ||
| "deprecated", | ||
| "openxr", | ||
| "retargeters", | ||
| "humanoid", | ||
| "fourier", | ||
| "data", | ||
| ) |
Collaborator
There was a problem hiding this comment.
That's a tad nasty. Couldn't that package provide us with these paths?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the Cfg and Implementation split in pink and mimic, this could help with import efficiency and reduce module eager loading.
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there