Skip to content

Adds assertion to catch Nans in pink#4743

Open
alexmillane wants to merge 1 commit intodevelopfrom
alex/fix/catch_nans_in_pink
Open

Adds assertion to catch Nans in pink#4743
alexmillane wants to merge 1 commit intodevelopfrom
alex/fix/catch_nans_in_pink

Conversation

@alexmillane
Copy link

Description

Tests the solution to pink IK for Nans. Falls back to doing nothing in the case it finds some. This restores the behaviour of Lab 2.3 (tolerance to failed IK).

Fixes # (issue)

Fixes the issue that the Isaac Lab process hangs (requiring kill -9) in the case of failed IK.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Screenshots

NA

Checklist

  • I have read and understood the contribution guidelines
  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 26, 2026

Too many files changed for review. (882 files found, 100 file limit)

@alexmillane alexmillane changed the base branch from main to develop February 26, 2026 12:56
@github-actions github-actions bot added bug Something isn't working documentation Improvements or additions to documentation asset New asset feature or request isaac-sim Related to Isaac Sim team isaac-mimic Related to Isaac Mimic team infrastructure labels Feb 26, 2026
@alexmillane alexmillane changed the title Alex/fix/catch nans in pink Catch Nans in pink Feb 26, 2026
@github-actions
Copy link

Test Results Summary

3 815 tests   3 221 ✅  3h 6m 10s ⏱️
  136 suites    559 💤
    1 files       12 ❌  23 🔥

For more details on these failures and errors, see this check.

Results for commit bd3ac8f.

Copy link
Collaborator

@AntoineRichard AntoineRichard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is needed somehow now.

@kellyguo11 kellyguo11 changed the title Catch Nans in pink Adds assertion to catch Nans in pink Feb 27, 2026
@kellyguo11
Copy link
Contributor

@michaellin6 are you good with this change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

asset New asset feature or request bug Something isn't working documentation Improvements or additions to documentation infrastructure isaac-mimic Related to Isaac Mimic team isaac-sim Related to Isaac Sim team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants