Open
Conversation
Contributor
|
Too many files changed for review. ( |
Test Results Summary3 815 tests 3 221 ✅ 3h 6m 10s ⏱️ For more details on these failures and errors, see this check. Results for commit bd3ac8f. |
AntoineRichard
approved these changes
Feb 26, 2026
Collaborator
AntoineRichard
left a comment
There was a problem hiding this comment.
This is needed somehow now.
Contributor
|
@michaellin6 are you good with this change? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Tests the solution to pink IK for Nans. Falls back to doing nothing in the case it finds some. This restores the behaviour of Lab 2.3 (tolerance to failed IK).
Fixes # (issue)
Fixes the issue that the Isaac Lab process hangs (requiring
kill -9) in the case of failed IK.Type of change
Screenshots
NA
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there