Skip to content

Adds Renderer Config Store#4759

Merged
kellyguo11 merged 3 commits intoisaac-sim:developfrom
bareya:pbarejko/renderer-with-hydra
Feb 27, 2026
Merged

Adds Renderer Config Store#4759
kellyguo11 merged 3 commits intoisaac-sim:developfrom
bareya:pbarejko/renderer-with-hydra

Conversation

@bareya
Copy link

@bareya bareya commented Feb 27, 2026

Description

  • Add Renderer Config Store
    • This allows to setup aliases for configurations
  • Remove code duplication
  • Update unit tests

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (existing functionality will not work without user modification)
  • Documentation update

Screenshots

Please attach before and after screenshots of the change if applicable.

Checklist

  • I have read and understood the contribution guidelines
  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

@bareya bareya requested a review from Mayankm96 as a code owner February 27, 2026 03:53
@github-actions github-actions bot added the isaac-lab Related to Isaac Lab team label Feb 27, 2026
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 27, 2026

Greptile Summary

Adds a new RendererConfigStore module that allows users to select renderer backends via Hydra config groups (e.g., render=isaac_rtx or render=newton_warp). The selected renderer config is automatically applied to all cameras in the environment. The implementation properly handles the optional isaaclab_newton dependency with try-except imports and conditional registration.

Key changes:

  • New render_config_store.py module registers renderer presets in Hydra ConfigStore
  • hydra.py adds default render config (isaac_rtx) and extracts process_hydra_config() to eliminate code duplication between production and test code
  • Tests validate default behavior, explicit overrides, and error handling for invalid configs
  • Newton-specific test properly uses @pytest.mark.skipif decorator

Previous review comments addressed:

  • Optional Newton imports now wrapped in try-except
  • Conditional registration checks if NewtonWarpRendererCfg is available before registering
  • Test for newton_warp properly skipped when dependency unavailable

No issues found.

Confidence Score: 5/5

  • This PR is safe to merge with no identified risks
  • Clean implementation with proper error handling for optional dependencies, comprehensive test coverage including edge cases, successful code deduplication, and all previous review concerns properly addressed
  • No files require special attention

Important Files Changed

Filename Overview
source/isaaclab_tasks/isaaclab_tasks/utils/render_config_store.py New module that registers renderer config presets for Hydra; properly handles optional Newton imports with try-except and conditional registration
source/isaaclab_tasks/isaaclab_tasks/utils/hydra.py Adds render config support with defaults, extracts shared process_hydra_config function to eliminate duplication; applies renderer config recursively to all camera objects
source/isaaclab_tasks/test/test_hydra.py Refactored to reuse process_hydra_config, adds comprehensive tests for render config defaults, overrides, and newton_warp (properly skipped when unavailable)

Last reviewed commit: 9e46775

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 files reviewed, 3 comments

Edit Code Review Agent Settings | Greptile

Copy link
Collaborator

@AntoineRichard AntoineRichard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bareya for the PR! Could you add the changes from Greptile, it would make sense to skip the test if newton is not there.

@kellyguo11 kellyguo11 changed the title Feature: Add Renderer Config Store Adds Renderer Config Store Feb 27, 2026
@kellyguo11
Copy link
Contributor

@greptile-apps

@kellyguo11 kellyguo11 merged commit 28bcbbd into isaac-sim:develop Feb 27, 2026
6 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

isaac-lab Related to Isaac Lab team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants