Skip to content

Reverts success condition in FixedBaseUpperBodyIKG1SceneCfg#4769

Merged
kellyguo11 merged 3 commits intoisaac-sim:developfrom
dengyuchenkit:ydeng/fix_test
Feb 28, 2026
Merged

Reverts success condition in FixedBaseUpperBodyIKG1SceneCfg#4769
kellyguo11 merged 3 commits intoisaac-sim:developfrom
dengyuchenkit:ydeng/fix_test

Conversation

@dengyuchenkit
Copy link

@dengyuchenkit dengyuchenkit commented Feb 27, 2026

Description

This PR reverts the success condition in FixedBaseUpperBodyIKG1SceneCfg

Fixes # (issue)

It fixes CI test:

./isaaclab.sh -p -m pytest source/isaaclab/test/controllers/test_pink_ik.py \ -k "Isaac-PickPlace-FixedBaseUpperBodyIK-G1-Abs-v0-horizontal_movement"

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read and understood the contribution guidelines
  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

@github-actions github-actions bot added bug Something isn't working documentation Improvements or additions to documentation isaac-lab Related to Isaac Lab team labels Feb 27, 2026
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 27, 2026

Greptile Summary

This PR correctly reverts the success termination condition in FixedBaseUpperBodyIKG1SceneCfg from locomanip_mdp.task_done_pick_place_table_frame back to manip_mdp.task_done_pick_place.

Key changes:

  • Removes the table-frame-aware success condition that was introduced in commit 5fcbb0d
  • Removes the table_cfg parameter from the termination condition
  • Fixes CI test failure in test_pink_ik.py which explicitly deletes packing_table from the scene (line 70 of test file) but the previous success condition tried to reference it, causing a runtime error
  • Also cleans up duplicate --visualizer kit flag in documentation

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • The revert is well-justified and fixes a real bug where the test environment doesn't spawn the table that the previous termination condition required. The change is a simple revert to previously working code, and both the old and new functions are properly imported and exist in the codebase.
  • No files require special attention

Important Files Changed

Filename Overview
source/isaaclab_tasks/isaaclab_tasks/manager_based/locomanipulation/pick_place/fixed_base_upper_body_ik_g1_env_cfg.py Reverts success termination from table-frame-aware version back to simpler version, fixing CI test that doesn't spawn the table
docs/source/overview/imitation-learning/humanoids_imitation.rst Removes duplicate --visualizer kit flag from command, keeping only --high_res_video

Last reviewed commit: f51a0ea

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

@kellyguo11 kellyguo11 changed the title Revert success condition in FixedBaseUpperBodyIKG1SceneCfg Reverts success condition in FixedBaseUpperBodyIKG1SceneCfg Feb 27, 2026
@kellyguo11 kellyguo11 merged commit de24ac3 into isaac-sim:develop Feb 28, 2026
8 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working documentation Improvements or additions to documentation isaac-lab Related to Isaac Lab team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants