Fixes deprecated teleop device factory to resolve class_type strings#4770
Closed
rwiltz wants to merge 2 commits intoisaac-sim:developfrom
Closed
Fixes deprecated teleop device factory to resolve class_type strings#4770rwiltz wants to merge 2 commits intoisaac-sim:developfrom
rwiltz wants to merge 2 commits intoisaac-sim:developfrom
Conversation
Contributor
Greptile SummaryThis PR fixes a Key changes:
The implementation correctly handles inheritance by walking the MRO to find the declaring class, ensuring Confidence Score: 5/5
Important Files Changed
Last reviewed commit: e18d95d |
kellyguo11
approved these changes
Feb 27, 2026
Collaborator
Contributor
|
should be addressed in #4765, will close this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix TypeError: issubclass() arg 1 must be a class in the deprecated create_teleop_device factory. Device configs (e.g. Se3KeyboardCfg) use {DIR} string placeholders in class_type that are only auto-resolved by @configclass, not plain @DataClass. The factory now resolves these strings before calling issubclass().
Add a new test (test_create_teleop_device_from_devices_cfg) that exercises the factory through the DevicesCfg pattern used by env configs.
Fixes # (issue)
Type of change
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there