Skip to content

Add bookmark functionality#777

Merged
jsharkey13 merged 37 commits into
mainfrom
feature/bookmarks
May 1, 2026
Merged

Add bookmark functionality#777
jsharkey13 merged 37 commits into
mainfrom
feature/bookmarks

Conversation

@axlewin
Copy link
Copy Markdown
Contributor

@axlewin axlewin commented Apr 21, 2026

Adds endpoints to allow users to bookmark/unbookmark question/concept pages and get a list of their bookmarked content. Also augments the /questions endpoint to include information about when a question was bookmarked, if at all.

Note that this doesn't augment the /concepts endpoint to include bookmarked status; this may be required depending on how we use this in the frontend.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 21, 2026

Codecov Report

❌ Patch coverage is 82.11921% with 27 lines in your changes missing coverage. Please review.
✅ Project coverage is 40.39%. Comparing base (657fb91) to head (c8ddd78).
⚠️ Report is 80 commits behind head on main.

Files with missing lines Patch % Lines
...n/java/uk/ac/cam/cl/dtg/isaac/dao/PgBookmarks.java 78.00% 8 Missing and 3 partials ⚠️
...va/uk/ac/cam/cl/dtg/isaac/api/BookmarksFacade.java 83.63% 3 Missing and 6 partials ⚠️
...am/cl/dtg/isaac/api/managers/BookmarksManager.java 88.57% 3 Missing and 1 partial ⚠️
...n/java/uk/ac/cam/cl/dtg/isaac/api/PagesFacade.java 66.66% 0 Missing and 1 partial ⚠️
.../isaac/configuration/IsaacApplicationRegister.java 0.00% 1 Missing ⚠️
...am/cl/dtg/isaac/dto/content/ContentSummaryDTO.java 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #777      +/-   ##
==========================================
+ Coverage   40.13%   40.39%   +0.26%     
==========================================
  Files         546      547       +1     
  Lines       23797    23722      -75     
  Branches     2900     2882      -18     
==========================================
+ Hits         9550     9582      +32     
+ Misses      13335    13245      -90     
+ Partials      912      895      -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread src/main/java/uk/ac/cam/cl/dtg/isaac/api/BookmarksFacade.java Fixed
Comment thread src/main/java/uk/ac/cam/cl/dtg/isaac/api/BookmarksFacade.java Fixed
Comment thread src/main/java/uk/ac/cam/cl/dtg/isaac/dos/PgBookmarks.java Fixed
Comment thread src/test/java/uk/ac/cam/cl/dtg/isaac/api/BookmarksFacadeIT.java Fixed
@axlewin axlewin marked this pull request as ready for review April 21, 2026 11:28
Comment thread src/main/java/uk/ac/cam/cl/dtg/isaac/api/BookmarksFacade.java Fixed
Comment thread src/test/java/uk/ac/cam/cl/dtg/isaac/api/BookmarksFacadeIT.java Dismissed
Comment thread src/test/java/uk/ac/cam/cl/dtg/isaac/api/BookmarksFacadeIT.java Dismissed
Comment thread src/main/java/uk/ac/cam/cl/dtg/isaac/api/BookmarksFacade.java Fixed
Comment thread src/main/java/uk/ac/cam/cl/dtg/isaac/api/BookmarksFacade.java Outdated
Comment thread src/main/java/uk/ac/cam/cl/dtg/isaac/api/BookmarksFacade.java Fixed
Comment thread src/main/java/uk/ac/cam/cl/dtg/isaac/api/managers/BookmarksManager.java Outdated
Comment thread src/main/java/uk/ac/cam/cl/dtg/isaac/api/BookmarksFacade.java Outdated
Comment thread src/main/java/uk/ac/cam/cl/dtg/isaac/api/BookmarksFacade.java Outdated
Comment thread src/main/java/uk/ac/cam/cl/dtg/isaac/api/BookmarksFacade.java Outdated
Comment thread src/main/java/uk/ac/cam/cl/dtg/isaac/dos/PgBookmarks.java Outdated
Comment thread src/main/java/uk/ac/cam/cl/dtg/isaac/dos/PgBookmarks.java Outdated
Comment thread src/test/java/uk/ac/cam/cl/dtg/isaac/api/BookmarksFacadeIT.java Dismissed
Comment thread src/main/java/uk/ac/cam/cl/dtg/isaac/api/BookmarksFacade.java Dismissed
Comment thread src/main/java/uk/ac/cam/cl/dtg/isaac/api/BookmarksFacade.java Dismissed
Comment thread src/main/java/uk/ac/cam/cl/dtg/isaac/api/managers/BookmarksManager.java Outdated
@jsharkey13 jsharkey13 merged commit 0d11ee4 into main May 1, 2026
5 checks passed
@jsharkey13 jsharkey13 deleted the feature/bookmarks branch May 1, 2026 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants