fix(release): make pre-release build work#23
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the pre-release workflow to fix issues with downloading treefmt binaries across different platforms. The workflow now uses a LATEST flag instead of PRERELEASE and introduces platform-specific version handling.
Key Changes:
- Replaced
PRERELEASEenvironment variable withLATESTandTREEFMT_VERSIONvariables for more explicit version control - Updated filename patterns from version-specific (
treefmt_2.0.0-rc*_...) to generic wildcards (treefmt_*_...) for non-Windows platforms - Windows platforms now explicitly use treefmt version v0.6.1, while other platforms fetch the latest release
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| latest: ${{ env.LATEST }} | ||
| tag: ${{ env.TREEFMT_VERSION }} |
There was a problem hiding this comment.
When latest is set to true, providing an empty string for tag may cause ambiguous behavior. For non-Windows platforms where LATEST is true and TREEFMT_VERSION is empty, consider omitting the tag parameter entirely or restructuring the logic to use either latest or tag, but not both simultaneously. This would make the intent clearer and align better with the action's API design.
| TREEFMT_VERSION="v0.6.1" | ||
| LATEST="false" |
There was a problem hiding this comment.
The hardcoded version "v0.6.1" for Windows platforms differs significantly from the latest release behavior used for other platforms. This creates inconsistency and makes maintenance harder. Consider adding a comment explaining why Windows requires this specific older version, or better yet, align all platforms to use the same versioning strategy if possible.
| TREEFMT_VERSION="v0.6.1" | |
| LATEST="false" | |
| TREEFMT_VERSION="" | |
| LATEST="true" |
update pre-release workflow
previosly it was set up for something slightly different