-
Notifications
You must be signed in to change notification settings - Fork 5
fix(release): make pre-release build work #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -58,31 +58,35 @@ jobs: | |
| shell: bash | ||
| run: | | ||
| if [[ "${{ matrix.platform }}" == 'windows' ]]; then | ||
| echo "PRERELEASE=false" >> $GITHUB_ENV | ||
| case "${{ matrix.arch }}" in | ||
| "amd64") FILENAME="treefmt-x86_64-pc-windows-msvc.zip";; | ||
| "arm64") FILENAME="treefmt-aarch64-pc-windows-msvc.zip";; | ||
| *) echo "Unsupported platform/arch combination" && exit 1;; | ||
| esac | ||
| TREEFMT_VERSION="v0.6.1" | ||
| LATEST="false" | ||
| else | ||
| echo "PRERELEASE=true" >> $GITHUB_ENV | ||
| case "${{ matrix.platform }}-${{ matrix.arch }}" in | ||
| "linux-amd64") FILENAME="treefmt_2.0.0-rc*_linux_amd64.tar.gz";; | ||
| "linux-arm64") FILENAME="treefmt_2.0.0-rc*_linux_arm64.tar.gz";; | ||
| "darwin-amd64") FILENAME="treefmt_2.0.0-rc*_darwin_amd64.tar.gz";; | ||
| "darwin-arm64") FILENAME="treefmt_2.0.0-rc*_darwin_arm64.tar.gz";; | ||
| "linux-amd64") FILENAME="treefmt_*_linux_amd64.tar.gz";; | ||
| "linux-arm64") FILENAME="treefmt_*_linux_arm64.tar.gz";; | ||
| "darwin-amd64") FILENAME="treefmt_*_darwin_amd64.tar.gz";; | ||
| "darwin-arm64") FILENAME="treefmt_*_darwin_arm64.tar.gz";; | ||
| *) echo "Unsupported platform/arch combination" && exit 1;; | ||
| esac | ||
| TREEFMT_VERSION="" | ||
| LATEST="true" | ||
| fi | ||
| echo "FILENAME=$FILENAME" >> $GITHUB_ENV | ||
| echo "TREEFMT_VERSION=$TREEFMT_VERSION" >> $GITHUB_ENV | ||
| echo "LATEST=$LATEST" >> $GITHUB_ENV | ||
|
|
||
| - name: Download treefmt | ||
| id: download-release | ||
| uses: robinraju/release-downloader@v1.10 | ||
| with: | ||
| repository: "numtide/treefmt" | ||
| latest: true | ||
| preRelease: ${{ env.PRERELEASE }} | ||
| latest: ${{ env.LATEST }} | ||
| tag: ${{ env.TREEFMT_VERSION }} | ||
|
Comment on lines
+88
to
+89
|
||
| fileName: ${{ env.FILENAME }} | ||
| out-file-path: "downloads" | ||
| extract: true | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The hardcoded version "v0.6.1" for Windows platforms differs significantly from the latest release behavior used for other platforms. This creates inconsistency and makes maintenance harder. Consider adding a comment explaining why Windows requires this specific older version, or better yet, align all platforms to use the same versioning strategy if possible.