Skip to content

Feature/implement frontend tests#45

Merged
olivhoenen merged 13 commits intoiterorganization:developfrom
mfiaudrin-epsyl:feature/implement_frontend_tests
Mar 24, 2026
Merged

Feature/implement frontend tests#45
olivhoenen merged 13 commits intoiterorganization:developfrom
mfiaudrin-epsyl:feature/implement_frontend_tests

Conversation

@mfiaudrin-epsyl
Copy link
Collaborator

@mfiaudrin-epsyl mfiaudrin-epsyl commented Mar 3, 2026

This feature implement frontend tests into the CI:

  • lint and formatting
  • build and packaging
  • E2E tests

It add a new E2E test to verify data integrity when applying ranges to a plot.

It also Fixes #43

@mfiaudrin-epsyl
Copy link
Collaborator Author

@olivhoenen, @prasad-sawantdesai
I have implemented frontend tests into the GitHub CI. Now, E2E tests are working, and I am adding a new one to test data integrity when applying ranges.

Currently, they are failing because this branch has a bug that has been fixed in PR #34, but I have tested them with the fix and it works.

Can you approve the PR #34 once it has been tested ? I need to merge developments to prevent from having conflicts in all branches still not approved in pull requests. During this time, I keep this PR as draft.

Best regards

@mfiaudrin-epsyl mfiaudrin-epsyl force-pushed the feature/implement_frontend_tests branch 27 times, most recently from 6fb7f7e to 0fb2111 Compare March 11, 2026 07:10
@mfiaudrin-epsyl mfiaudrin-epsyl force-pushed the feature/implement_frontend_tests branch 11 times, most recently from 02e2b78 to e089ec2 Compare March 13, 2026 15:48
@mfiaudrin-epsyl
Copy link
Collaborator Author

Hello @olivhoenen, @deepakmaroo,
E2E tests are passing. I had temporarily removes the one with error bars since I didn't found any data having error bars in Zenodo. If you have an example, could you please give me it.

Copy link
Contributor

@prasad-sawantdesai prasad-sawantdesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mfiaudrin-epsyl Could you please keep frontend CI scripts which we could also run on bamboo.. These are fixed in separate PR..

https://github.com/iterorganization/IBEX/pull/41/changes#diff-7101a306ad43ac5ca5da25bb71a717a3a5ea8515a1b635436acdc404b18a25f7

@olivhoenen
Copy link
Contributor

Hello @olivhoenen, @deepakmaroo, E2E tests are passing. I had temporarily removes the one with error bars since I didn't found any data having error bars in Zenodo. If you have an example, could you please give me it.

We have access to some example of experimental data with error bars on SDCC, but it does not belong to IO so we can't open access on Zenodo unfortunately. Temporary removing the test with these is fine, anyway we want a better visual implementation with error bands and not individual bars for each data point.

@mfiaudrin-epsyl
Copy link
Collaborator Author

Hi @deepakmaroo, @olivhoenen,
I have rebase the branch from develop

Copy link
Contributor

@olivhoenen olivhoenen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

E2E UI tests failing on ITER CI

4 participants