Code Review Suggestions - Motakean

[motakean]

---

[motakean]

It's important to seperate the column names with a "_" inbetween.

source: https://developer.android.com/training/data-storage/room/defining-data

[motakean]

Added kdoc documention to better help the functionality of the data class.
https://kotlinlang.org/docs/kotlin-doc.html#block-tags

[motakean]

Instead of using @query and deleteall, we can use a simple @delete and delete method to make the code more clear and concise.

Source: https://developer.android.com/training/data-storage/room/accessing-data

[discospiff]

This same suggestion appeared in a previously submitted code review.
When that occurs, only the first gets credit.

[motakean]

Analysis of the program:
This program is medicine tracking app for patients to ensure they're taking their medicine on time and appropriately. It consists of files such as the DAO, DTO, a database, and view model.

Was the program available in UC Github on time?
Yes

Is the program documented/commented well enough for you to understand?
Overall, the program was documented well, but I added additional documentations/comments such as KDoc

Does the program compile?
No, the program did not compile for me.

Rationale behind your changes:
The suggestions given are mostly to imporve on documentation, readability, etc. When inputting data, especially with the column names, we have to ensure that there is an underline seperating the two words, and ensure that they are lowercase. Table and column names in SQLite are case-insensitive. As for the deletion, I would suggest just using @delete instead of @query to make it more simple to delete, and more easier to follow. I also implemented some KDoc so that reviewers, such as myself, may find it easier to understand certain things.

Sources:

https://developer.android.com/training/data-storage/room/defining-data
https://kotlinlang.org/docs/kotlin-doc.html#block-tags
[https://developer.android.com/training/data-storage/room/accessing-data

Links to three specific commits that you made to your own group's GitHub repository before the end of sprint deadline.
Fastovich/PlaceFinder@392a546
Fastovich/PlaceFinder@1e7b98d
Fastovich/PlaceFinder@f908d79

Three specific technical concepts that you learned from this code review:
-The use of SQLite to create databases with columns within code.
-Column names are required to have an underscore if there is spacing between the words.
-The proper use of Kdocumentation and how to use it in Kotlin.

[discospiff]

The changes here are fairly minor; no need to merge this branch. I would harvest the updated database names (with underscores instead of spaces), and good KDoc practices throughout.

Also, the reviewer indicates that the project does not compile. Only code that compiles should be pushed to version control. So, if it does not compile, the group should focus on fixing that first, before making any additional changes.