Fix stale comments: helter membership is explicit#54
Merged
Conversation
sync-heros.py auto-adds helter to every hero's memberships list, so it appears explicitly in the YAML. provision-groups.py reads memberships explicitly with no special helter logic.
Terraform PlanNo changes — infrastructure is up to date. Plan output |
Alexanderamiri
added a commit
that referenced
this pull request
May 9, 2026
## Summary - `provision-groups.py` docstring incorrectly said heroes are implicitly in helter - `sync-heros.py` generated YAML comment said helter is "not listed in memberships" In reality, `sync-heros.py` auto-adds `helter` to every hero's memberships list (line 194), and `provision-groups.py` reads memberships explicitly with no special helter logic (line 36).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
provision-groups.pydocstring incorrectly said heroes are implicitly in heltersync-heros.pygenerated YAML comment said helter is "not listed in memberships"In reality,
sync-heros.pyauto-addshelterto every hero's memberships list (line 194), andprovision-groups.pyreads memberships explicitly with no special helter logic (line 36).