Skip to content

Fix stale comments: helter membership is explicit #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Alexanderamiri merged 1 commit into from
Mar 12, 2026
Merged

Fix stale comments: helter membership is explicit #54

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/provision-groups.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
the memberships field in heros.yaml, and invokes the javabin-team-provisioner
Lambda with action=sync_groups_and_heros.

All heroes are implicitly members of the 'helter' group.
All group memberships are explicit — heroes must list each group in their memberships field.

Requires: aws CLI, PyYAML (available on GitHub Actions ubuntu-latest runners)
"""
Expand Down
2 changes: 1 addition & 1 deletion scripts/sync-heros.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ def format_yaml(members):
"# creates a PR updating this file.",
"#",
"# Rules:",
"# - All members are implicitly in the 'helter' group (not listed in memberships)",
"# - The sync script auto-adds 'helter' to every hero's memberships",
"# - memberships references group names from groups.yaml",
"# - alias is optional — heroes can PR their preferred alias",
"# - javabin_google_email is the Google Workspace account (firstname.lastname@java.no)",
Expand Down