Upstream submodule cutover: remove duplicated root upstream files, add readiness checks, docs, and tests#18
Conversation
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 69270191f1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "version": "0.85.0", | ||
| "bin": { | ||
| "devcontainer": "devcontainer.js" | ||
| "devcontainer": "upstream/devcontainer.js" |
There was a problem hiding this comment.
Keep installer entrypoint aligned with new npm bin path
Changing the bin target to upstream/devcontainer.js moves the packaged executable to package/upstream/devcontainer.js, but the standalone installer still hardcodes package/devcontainer.js (scripts/install.sh checks/uses that path in install_cli, wrapper generation, and verification). That makes fresh standalone installs fail with “entry point not found” even when the tarball is otherwise valid, because the wrapper points to a file path that no longer exists after this package.json change.
Useful? React with 👍 / 👎.
| @@ -1,61 +0,0 @@ | |||
| /*--------------------------------------------------------------------------------------------- | |||
There was a problem hiding this comment.
Restore an ESLint flat config for lint/precommit workflows
Removing eslint.config.mjs leaves the repo without any eslint.config.(js|mjs|cjs), so yarn lint now exits immediately with “ESLint couldn't find an eslint.config... file” (ESLint v10). This blocks the CI lint job (.github/workflows/dev-containers.yml, L35) and also breaks build/hygiene.js/precommit because new ESLint() cannot load configuration.
Useful? React with 👍 / 👎.
|
@codex fix comments |
Summary
Testing
Committed as |
Merge pull request #18 from jooh/codex/implement-upstream-submodule-cutover-step-919m0s Upstream submodule cutover: remove duplicated root upstream files, add readiness checks, docs, and tests
Motivation
upstream/the canonical location for upstream TypeScript CLI sources and remove byte-for-byte duplicates at the repository root to simplify ownership and reduce drift.Description
CHANGELOG.md,LICENSE.txt,ThirdPartyNotices.txt,devcontainer.js,CODEOWNERS,CONTRIBUTING.md,.gitignore,.gitattributes,tsconfig.base.json,eslint.config.mjs,yarn.lock, etc.) and updatedREADME.mdto document the upstream submodule workflow and compatibility contract.package.jsonto point the CLIbintoupstream/devcontainer.js, adjustedfilesentries to referenceupstream/copies, and added npm scripts for submodule/compatibility checks (check-upstream-submodule,check-upstream-compatibility).src/spec-node/migration/upstreamSubmoduleCutoverReadiness.tsincludingcollectRootLevelDuplicateUpstreamFiles,collectUpstreamSubmoduleDocumentationGaps, and related helpers that detect duplicate root files, path references to upstream-owned assets, and missing documentation markers.src/test/upstreamSubmoduleCutoverReadiness.test.tsand adjusted test config to referenceupstream/(src/test/tsconfig.json), plus small docs and TODO updates (e.g.,docs/standalone/cutover.md,TODO.md) to reflect the cutover state.Testing
npm test(Mocha) including the newupstreamSubmoduleCutoverReadinesstests, and all tests passed.collectRootLevelDuplicateUpstreamFilesandcollectRootLevelUpstreamPathReferences, and they passed in CI/local runs.npm run check-upstream-submoduleandnpm run check-upstream-compatibilityas part of the readiness workflow, and both checks behaved as expected (no failures against the pinnedupstream/baseline).Codex Task