Skip to content

ci: remove unsupported macOS runner from install-script matrix #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jooh merged 2 commits into from
Apr 3, 2026
Merged

ci: remove unsupported macOS runner from install-script matrix #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4385cee
ci: remove macOS install-script runner from matrix
jooh Apr 3, 2026
d1358dd
build: sanitize CONFIGURATION env for npm build scripts
jooh Apr 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/dev-containers.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,9 @@ jobs:
strategy:
fail-fast: false
matrix:
os: [ubuntu-latest, macos-latest]
# macOS runners are not available in all org/repo configurations.
# Keep this matrix to universally available hosted runners.
os: [ubuntu-latest]
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v6
Expand Down
30 changes: 30 additions & 0 deletions build/sanitize-env.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
/*---------------------------------------------------------------------------------------------
* Copyright (c) Microsoft Corporation. All rights reserved.
* Licensed under the MIT License. See License.txt in the project root for license information.
*--------------------------------------------------------------------------------------------*/

'use strict';

const { spawnSync } = require('child_process');

const [, , command, ...args] = process.argv;

if (!command) {
console.error('Usage: node build/sanitize-env.js <command> [args...]');
process.exit(1);
}

const env = { ...process.env };
delete env.CONFIGURATION;

const result = spawnSync(command, args, {
stdio: 'inherit',
env,
shell: process.platform === 'win32',
});

if (typeof result.status === 'number') {
process.exit(result.status);
}

process.exit(1);
10 changes: 5 additions & 5 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,14 +18,14 @@
"node": ">=20.0.0"
},
"scripts": {
"compile": "npm-run-all clean-dist compile-dev",
"watch": "npm-run-all clean-dist compile-watch",
"package": "npm-run-all clean-dist compile-prod store-packagejson patch-packagejson npm-pack restore-packagejson",
"compile": "node build/sanitize-env.js npm-run-all clean-dist compile-dev",
"watch": "node build/sanitize-env.js npm-run-all clean-dist compile-watch",
"package": "node build/sanitize-env.js npm-run-all clean-dist compile-prod store-packagejson patch-packagejson npm-pack restore-packagejson",
"store-packagejson": "copyfiles package.json build-tmp/",
"patch-packagejson": "node build/patch-packagejson.js",
"restore-packagejson": "copyfiles --up 1 build-tmp/package.json .",
"type-check": "npm-run-all clean-built tsc-b",
"type-check-watch": "npm-run-all clean-built tsc-b-w",
"type-check": "node build/sanitize-env.js npm-run-all clean-built tsc-b",
"type-check-watch": "node build/sanitize-env.js npm-run-all clean-built tsc-b-w",
"compile-prod": "node esbuild.js --production",
"compile-dev": "node esbuild.js",
"compile-watch": "node esbuild.js --watch",
Expand Down