docs/ci: Renode driver listing and conditional macOS Renode install#557
Conversation
Include jumpstarter-driver-renode in the drivers reference index and hidden toctree so Sphinx no longer warns that renode.md is orphaned. Remove the Design Decisions link to the old ADR path from the Renode README (also published via the renode.md symlink) to avoid myst cross-reference failures until a stable internal doc link exists. Made-with: Cursor
📝 WalkthroughWalkthroughThe pull request adds Renode to the drivers documentation index as a "Debug and Programming" driver package, including both a documentation entry and toctree reference. Simultaneously, it removes a reference to ADR-0001 from the Renode driver package's README file. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| The architectural choices for this driver are documented in | ||
| [ADR-0001: Renode Integration Approach](../../docs/source/contributing/adr/0001-renode-integration.md). | ||
|
|
There was a problem hiding this comment.
the doc is in the internal directory and can't be grabbed by sphinx
There was a problem hiding this comment.
🧹 Nitpick comments (1)
python/docs/source/reference/package-apis/drivers/index.md (1)
116-159: Consider alphabetical ordering in the toctree (optional).The hidden toctree entries are not consistently alphabetically ordered. For example,
gpiod.mdappears afterrenode.mdwhen it should come earlier alphabetically. While this doesn't affect functionality, maintaining alphabetical order improves maintainability and makes it easier to spot missing entries.This is a pre-existing organizational inconsistency and not introduced by this PR, so it could be addressed in a separate cleanup if desired.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@python/docs/source/reference/package-apis/drivers/index.md` around lines 116 - 159, Reorder the hidden toctree entries in the drivers index so they are alphabetically sorted (e.g., move gpiod.md to appear before renode.md); edit the toctree block containing the listed filenames (adb.md, androidemulator.md, ..., yepkit.md) and sort all filenames lexicographically to ensure consistent maintainability.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@python/docs/source/reference/package-apis/drivers/index.md`:
- Around line 116-159: Reorder the hidden toctree entries in the drivers index
so they are alphabetically sorted (e.g., move gpiod.md to appear before
renode.md); edit the toctree block containing the listed filenames (adb.md,
androidemulator.md, ..., yepkit.md) and sort all filenames lexicographically to
ensure consistent maintainability.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: b4099c0d-9c91-42f9-9637-f85bdca152f5
📒 Files selected for processing (2)
python/docs/source/reference/package-apis/drivers/index.mdpython/packages/jumpstarter-driver-renode/README.md
💤 Files with no reviewable changes (1)
- python/packages/jumpstarter-driver-renode/README.md
Add a paths-filter rule for jumpstarter-driver-renode and gate the slow Homebrew install on that output (or workflow_dispatch for full manual runs). Linux keeps the fast .deb install for every matrix job. Made-with: Cursor
Summary
Documentation
jumpstarter-driver-renode) in the drivers reference index and the hiddentoctree, sorenode.md(symlinked from the package README) is part of the Sphinx tree and the “document isn’t included in any toctree” warning goes away.contributing/adr/0001-renode-integration.md), which no longer exists and caused MyST xref failures undermake docs(-W).No change to the in-repo JEP under
docs/internal/jeps/; we can add a link again once the team agrees on how to reference it from published docs.CI (Python Tests workflow)
brew install renode/tap/renodeis slow (~5+ minutes per job). It now runs only when the change set touchespython/packages/jumpstarter-driver-renode/**(viapaths-filter), or onworkflow_dispatchso manual runs still get full coverage..debinstall remains for every matrix job (fast).Testing
make docs(frompython/)