fix: handle afterLease timeout and retry Dial on RESOURCE_EXHAUSTED#600
Draft
raballew wants to merge 2 commits intojumpstarter-dev:mainfrom
Draft
fix: handle afterLease timeout and retry Dial on RESOURCE_EXHAUSTED#600raballew wants to merge 2 commits intojumpstarter-dev:mainfrom
raballew wants to merge 2 commits intojumpstarter-dev:mainfrom
Conversation
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…nning afterLease hook When the lease duration expires on the controller while the afterLease hook is still running, the controller tears down the router connection. The client's status monitor detects this as connection lost. Previously, the client treated connection loss during AFTER_LEASE_HOOK as an error, raising ExporterOfflineError. This is incorrect because the exporter is still running the hook autonomously -- only the monitoring connection was lost. The fix separates the handling: connection loss while the hook has FAILED is still an error, but connection loss while the hook is still RUNNING is handled gracefully with an informational log message. The afterLease result handling logic is also extracted into a standalone _handle_after_lease_result function for testability. Generated-By: Forge/20260416_202053_681470_d8e513a2_i243 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…sendToListener The controller's sendToListener now uses a non-blocking channel send that returns RESOURCE_EXHAUSTED when the listener buffer is full instead of blocking. Add RESOURCE_EXHAUSTED to the client-side Dial retry loop so callers transparently recover from this transient condition. Generated-By: Forge/20260416_202053_681470_d8e513a2_i243 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
raballew
force-pushed
the
051-afterlease-timeout-fix
branch
from
05442e3 to
bf49a31
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RESOURCE_EXHAUSTEDto the client-side Dial retry loop so callers recover from the controller's non-blockingsendToListenerchannel sendafterLease: loss while hook is RUNNING is now graceful (informational log), only FAILED triggersExporterOfflineErrorCloses #243
Test plan
make pkg-test-jumpstarter-cliandmake pkg-test-jumpstarter🤖 Generated with Claude Code