ssh-mount: follow-up improvements from PR #434 review#630
Open
ambient-code[bot] wants to merge 1 commit intofeature/322-filesystem-mountfrom
Open
ssh-mount: follow-up improvements from PR #434 review#630ambient-code[bot] wants to merge 1 commit intofeature/322-filesystem-mountfrom
ambient-code[bot] wants to merge 1 commit intofeature/322-filesystem-mountfrom
Conversation
- Extract shared SSH utility logic into _ssh_utils.py (create_temp_identity_file, cleanup_identity_file) used by both SSHWrapperClient and SSHMountClient - Fix LSP deviation: SSHMountClient now inherits from DriverClient instead of CompositeClient, with explicit ssh property for child access - Replace single 1s wait + ismount check with polling loop (0.5s intervals, 10s timeout) for mount readiness on slow connections - Document allow_other security implications in README - Restructure tests: separate _build_sshfs_args unit tests, use pytest fixtures to flatten nested patch blocks, add fd-cleanup coverage for temp identity file creation, use side_effect for _find_executable mocks consistently Ref: #597 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_ssh_utils.py) for temp identity file creation/cleanup, eliminating duplication betweenSSHWrapperClientandSSHMountClientSSHMountClientnow inherits fromDriverClientinstead ofCompositeClient(mount is a single command, not a group)os.path.ismount()check with a polling loop (0.5s intervals, 10s timeout) for robustness on slow connectionsallow_othermount option security implications in README_build_sshfs_argsunit tests, pytest fixtures to flatten nesting, new fd-cleanup coverage, consistentside_effectfor_find_executablemocksTest plan
jumpstarter-driver-sshtests passjumpstarter-driver-ssh-mounttests pass (up from 26 — added 8_build_sshfs_argsunit tests + 1 fd-cleanup test)make lint-fix)Ref: #597
🤖 Generated with Claude Code