fix(dashboard): complete stale socket guards, cross-platform shortcut, quest navigation#84
Merged
justinjdev merged 2 commits intofeat/command-dashboardfrom Mar 21, 2026
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…ard shortcut - Add `ws !== socket` guard to onmessage and onerror handlers in websocket.ts to prevent stale socket instances from mutating shared state during reconnection races - Add CONNECTING state check to prevent duplicate connection attempts - Normalize keyboard shortcut key check with toLowerCase() for cross-platform robustness (Caps Lock edge case) Addresses CodeRabbit review comments from PR #76. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…onerror cleanup - Reset dataLoaded/loadFailed state when questName changes to prevent stale data when navigating between quest detail pages - Revert onerror stale guard — errored sockets should always be closed for cleanup; the onclose handler already guards shared state Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
justinjdev
force-pushed
the
worktree-fellowship-fix-frontend-ux
branch
from
2f5c19c to
219142e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ws !== socketcheck toonmessagehandler and CONNECTING state check to prevent duplicate connectionstoLowerCase()in Shell.svelte for cross-platform robustnessAddresses CodeRabbit review comments from PR #76.
Test plan
npm run checkpasses in dashboard/🤖 Generated with Claude Code