Skip to content

fix(dashboard): complete stale socket guards, cross-platform shortcut, quest navigation #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
justinjdev merged 2 commits into from
Mar 21, 2026
Merged

fix(dashboard): complete stale socket guards, cross-platform shortcut, quest navigation #84

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
713f099
fix(dashboard): complete stale socket guards and cross-platform keybo…
justinjdev Mar 21, 2026
219142e
fix(dashboard): address balrog findings — quest navigation reset and …
justinjdev Mar 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dashboard/src/lib/components/Shell.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
let paletteOpen = $state(false);

function handleKeydown(e: KeyboardEvent) {
if (e.key === 'k' && (e.metaKey || e.ctrlKey)) {
if (e.key.toLowerCase() === 'k' && (e.metaKey || e.ctrlKey)) {
e.preventDefault();
paletteOpen = !paletteOpen;
}
Expand Down
3 changes: 2 additions & 1 deletion dashboard/src/lib/stores/websocket.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ function getWSUrl(): string {
}

function connect() {
if (ws?.readyState === WebSocket.OPEN) return;
if (ws && (ws.readyState === WebSocket.OPEN || ws.readyState === WebSocket.CONNECTING)) return;

let socket: WebSocket;
try {
Expand Down Expand Up @@ -63,6 +63,7 @@ function connect() {
};

socket.onmessage = (event) => {
if (ws !== socket) return;
try {
const data: WSEvent = JSON.parse(event.data);
lastEvent.set(data);
Expand Down
9 changes: 9 additions & 0 deletions dashboard/src/routes/quest/[id]/+page.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,15 @@

let loading = $state(false);

// Reset data when navigating between quests (component is reused)
$effect(() => {
questName;
dataLoaded = false;
loadFailed = false;
errandList = null;
tomeData = null;
});

$effect(() => {
if (quest && !dataLoaded && !loadFailed && !loading) {
loading = true;
Expand Down